1142790 - Add a test for passing Request objects to DOM cache matchAll method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Add a test for passing Request objects to DOM cache matchAll method

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8576985 [details] [diff] [review]
Add a test for passing Request objects to DOM cache matchAll method

Review of attachment 8576985 [details] [diff] [review]:
-----------------------------------------------------------------

All the comments from bug 1142333 apply here as well.  We need to check the various combinations of values in the CacheQueryOptions that can be passed to MatchAll(), etc.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8576985 [details] [diff] [review]
Add a test for passing Request objects to DOM cache matchAll method

We're going to do follow-ups for missing stuff.

Comment 4

[(no longer active)]

Attachment: Add a test for passing Request objects to DOM cache matchAll method

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bd38b652695

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/409fe8e38ee6 for making test_cache_match_request.html frequently fail.


https://treeherder.mozilla.org/logviewer.html#?job_id=7609806&repo=mozilla-inbound

Comment 7

[(no longer active)]

Sorry relanded since I have a ton of stuff built on top of this:

https://hg.mozilla.org/integration/mozilla-inbound/rev/80a2308b5cc8

I filed bug 1143222 to investigate and disabled these two tests for now.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/80a2308b5cc8