Closed Bug 1142835 Opened 7 years ago Closed 7 years ago

[EME] GMP crash causes Firefox to crash

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: eflores, Assigned: eflores)

References

Details

Attachments

(1 file)

Adding an abort() call to ClearKeySessionManager::UpdateSession causes not only the plugin-container to crash, but firefox as well.

[844] WARNING: Trying to use a dead GMP Audio decoder!: file c:\Users\me\src\evil-central\dom\media\gmp\GMPAudioDecoderParent.cpp, line 106
[844] ###!!! ASSERTION: You can't dereference a NULL nsRefPtr with operator->().: 'mRawPtr != 0', file c:\Users\me\src\evil-central\xpcom\base\nsRefPtr.h, line 236
Assignee: nobody → edwin
Blocks: 1148071
Status: NEW → ASSIGNED
Worth noting that GMPVDP already has this. Must have slipped through the cracks.
Attachment #8585245 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/33b68aec2ab9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment on attachment 8585245 [details] [diff] [review]
adp-assert.patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: Users shouldn't see this, as it's only in debug builds. However if we don't uplift this, we (the developers) will hit crashes when working on aurora/beta trees.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests, which sometimes crash without this patch.
[Risks and why]: Very low; this patch adds null pointer checks to code that only runs in debug builds.
[String/UUID change made/needed]: None.
Attachment #8585245 - Flags: approval-mozilla-beta?
Attachment #8585245 - Flags: approval-mozilla-aurora?
Flags: needinfo?(cpearce)
Comment on attachment 8585245 [details] [diff] [review]
adp-assert.patch

We want to simplify the life of developers. Taking it. Should be in 38 beta 3
Don't need aurora uplift as it landed before the last merge.
Attachment #8585245 - Flags: approval-mozilla-beta?
Attachment #8585245 - Flags: approval-mozilla-beta+
Attachment #8585245 - Flags: approval-mozilla-aurora?
Attachment #8585245 - Flags: approval-mozilla-aurora-
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.