Closed Bug 1142850 Opened 9 years ago Closed 9 years ago

Add an hourly cron job to update credits data file

Categories

(www.mozilla.org :: Bedrock, defect)

Product:
www.mozilla.org
Component:
Bedrock
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pmac, Unassigned)

References

Details

This will also include all of the files under the external_files system in bedrock. Gerv asked that we do this in bug 801909.

This will require a new deployment script like the one for locales that will update the file and when it finds a new version will sync it out to the webheads.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/5435b548ea2a1a4563f3009db29dfc1fc4d2e432
Fix bug 1142850: Add cron job to update external files hourly.

https://github.com/mozilla/bedrock/commit/6d87486a3bccc99b3ad85330b78b4d73fdcc81f8
Merge pull request #2837 from pmclanahan/update-external-files-cron-1142850

Fix bug 1142850: Add cron job to update external files hourly.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
pmac: so this is checked in, but won't become active until the site next ships?

Gerv
Correct. Should be in the next day or two. I'll update the bug when it's live.
:pmac: did this go live? I just made a set of updates, but they aren't appearing.

Gerv
Also, I don't see the URL of names.csv in the patch... does that go elsewhere?

Gerv
Flags: needinfo?(pmac)
Yes. Sorry. This is live and has been for a while. Is it still not updated? It runs hourly but then the page is also cached for a while. 

The names.csv config was added when we initially added the credits to bedrock. It's here:

https://github.com/mozilla/bedrock/blob/3c1f879111cc4f8a9eb005e20b4ff9766ba4c0ec/bedrock/settings/base.py#L470
Flags: needinfo?(pmac)
pmac: about:credits has a last-updated date at the bottom, and it currently says "April 16th". However:

gerv@hare:~$ svn log /usr/src/mozilla.org/credits/names.csv | head
------------------------------------------------------------------------
r142674 | gerv@mozilla.org | 2015-06-19 08:59:46 -0700 (Fri, 19 Jun 2015) | 1 line

Andrew Bartlett <abartlet@samba.org>: "NTLMv2 support; NTLM bug-fixing"


Can you look into why it's not updating?

Gerv
Flags: needinfo?(pmac)
I believe I've got this fixed. It looks to be correct to me on the server, but the cache is still causing it to show the old content. It should update in the next hour or so, and after that it should update as expected. Please reopen or file a new bug if this doesn't happen.
Flags: needinfo?(pmac)
Yep, this seems to have worked now - last updated June 19th.

Gerv
You need to log in before you can comment on or make changes to this bug.