Remove the parent argument from NewObjectWithGroup

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla39
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 8577078 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup
Attachment #8577078 - Flags: review?(jwalden+bmo)
Created attachment 8577376 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup
Attachment #8577376 - Flags: review?(jwalden+bmo)
Attachment #8577078 - Attachment is obsolete: true
Attachment #8577078 - Flags: review?(jwalden+bmo)
Comment on attachment 8577376 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup

Review of attachment 8577376 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/UnboxedObject.cpp
@@ +507,1 @@
>                                                                       allocKind, newKind);

UPO *res =
    NewObjectWithGroup<UPO>(...);

should amke this more readable, I think.
Attachment #8577376 - Flags: review?(jwalden+bmo) → review+
Done, and https://hg.mozilla.org/integration/mozilla-inbound/rev/7128e4104f94
https://hg.mozilla.org/mozilla-central/rev/7128e4104f94
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.