Closed Bug 1142865 Opened 7 years ago Closed 7 years ago

Remove the parent argument from NewObjectWithGroup

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8577078 - Flags: review?(jwalden+bmo)
Attachment #8577078 - Attachment is obsolete: true
Attachment #8577078 - Flags: review?(jwalden+bmo)
Comment on attachment 8577376 [details] [diff] [review]
Remove the parent argument from NewObjectWithGroup

Review of attachment 8577376 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/UnboxedObject.cpp
@@ +507,1 @@
>                                                                       allocKind, newKind);

UPO *res =
    NewObjectWithGroup<UPO>(...);

should amke this more readable, I think.
Attachment #8577376 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/7128e4104f94
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.