Closed Bug 1142879 Opened 5 years ago Closed 5 years ago

[meta] track Mozilla-central (Core) issues that we want to have fixed in TB38

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird38 fixed)

RESOLVED FIXED
Tracking Status
thunderbird38 --- fixed

People

(Reporter: jorgk-bmo, Unassigned)

References

Details

(Keywords: meta)

TB is affected by the following core bugs. This is the TB metabug to keep track of them.

All of these issues have patches proposed, so we need to keep track of these patches landing and "lobby" to get these patches into Gecko 38.

Issues are in the area of mail composition:
bug 1141017 - sans serif (affecting font indicator in TB, bug 1139524)
bug 1140105 - another font problem with collapsed selection affecting TB font menu
bug  756984 - losing font at end of line, layout problem, long-standing annoyance
bug 1042561 - red recipients (auto-complete), an issue ever since TB 31.x
bug 1100966 - spell ranges getting lost, editor problem, long-standing annoyance

Issues in other areas:
(none so far)
Keywords: meta
Jorg, your bug summary does not reflect your intention, which surely is not "track all the Mozilla-central issues affecting TB" because there are literally hundreds of such bugshttp://mzl.la/1NVNB96

Meta bugs, like normal bugs, are most effective when they are narrowly scoped, lest it get hijacked by others for purposes you did not intend.  I suspect what you intend is "track Mozilla-central (Core) issues that we want to have fixed in TB38". Is that accurate?
Summary: Metabug to track all the Mozilla-central issues affecting TB → [meta] track all the Mozilla-central issues affecting TB
Yes.
Summary: [meta] track all the Mozilla-central issues affecting TB → [meta] track Mozilla-central (Core) issues that we want to have fixed in TB38
Update:

bug 1141017 - sans serif (affecting font indicator in TB, bug 1139524)
Not ready yet. However, fixes to bug 1139524 and bug 1148330 solve this problem for now.

bug 1140105 - another font problem with collapsed selection affecting TB font menu
Not ready yet.

bug  756984 - losing font at end of line, layout problem, long-standing annoyance
Landed on mozilla39, landing on mozilla38 was declined. However, bug 756984 comment #132 suggests to "cherry-pick" this patch for TB 38. *Is this possible, Kent?*

bug 1042561 - red recipients (auto-complete), an issue ever since TB 31.x
Landed on mozilla38 and 39.

bug 1100966 - spell ranges getting lost, editor problem, long-standing annoyance
Landed on mozilla39, landing on mozilla38 was declined.
Flags: needinfo?(kent)
"However, bug 756984 comment #132 suggests to "cherry-pick" this patch for TB 38. *Is this possible, Kent?*"

I believe what was suggested is to compile Thunderbird from a Thunderbird-specific branch of mozilla-central (or apply patches during build) so that we are not using the identical core code to Firefox, but our own variant of it.

I suggested that we do this as standard practice during the Thunderbird 2014 Toronto Summit, but there was not much support for it. Yet I do this routinely in my builds for ExQuilla where I have similar issues. It creates a lot of extra work if there is not infrastructure for it, but it is not that hard to maintain in my experience once you have it setup well. It has been done IIUC occasionally in the past for Thunderbird as well, but not routinely.

Fallen suggested recently that shipping Lightning with Thunderbird may also require this. If we end up going down that route, I could see also adding in some of the patches needed for editor. There would need to be multiple important issues to develop enough support for the extra effort.
Flags: needinfo?(kent)
Update April 21st:
Bug 756984 (losing fonts while typing e-mail) is worth taking (landed on mozilla39).
Bug 1100966 (lost spell check marks) is worth taking (landed on mozilla39).
Sadly, that was only a partial fix: Bug 1154791 is need to fix it fully. This will land soon (actually, already landed on mozilla40 but backed out for unknown reason)
We will decide before Thunderbird 38 beta 4 next week if we will use a release branch for mozilla in Thunderbird 38. If we do, we will consider trying these patches in Thunderbird 38.
Depends on: 1159817
I think this is resolved now, the fixes to the core bugs we really needed have landed on THUNDERBIRD_38_VERBRANCH.

Bug 1141017 is not necessary, since that was adequately fixed in the the TB client.

Bug 1140105 is hard to include, since sadly its patch (attachment 8597247 [details] [diff] [review]) would fail to apply on mozilla38 since the patch happened after a major editor reshuffle in bug 1147412.

If bug 1140105 were to be included in TB38, it would have to be with (a slightly modified) attachment 8595402 [details] [diff] [review]. I can supply it, if anyone is interested.
Depends on: 1159923
Done, bug 1159923. I've stuck the patch in there.
All done, unbelievable ;-)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
So many thanks to you guys!

Now just have to wait for it to roll into the release channel.
But we are happy happy happy.
You need to log in before you can comment on or make changes to this bug.