Closed Bug 1142919 Opened 6 years ago Closed 6 years ago

[RTL][First Time Experience]The OK and Skip buttons are not swapped.

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.2+, b2g-v2.2 affected, b2g-master affected)

VERIFIED INVALID
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- affected
b2g-master --- affected

People

(Reporter: lulu.tian, Assigned: apastor)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Attached image Input PIN.png
[1.Description]:
[RTL][v2.2 & v3.0][First Time Experience]The OK and Skip buttons are not swapped when we input SIM PIN at FTE.
See attachment:Input PIN.png

[2.Testing Steps]: 
1. Insert SIM card with PIN code in device and set your phone language to Arabic in FTE.
2. Tap "Next" button in Language page. 
3. Observe the enter PIN view. 

[3.Expected Result]: 
3. The OK and Skip buttons should be swapped. 

[4.Actual Result]: 
3. The OK and Skip buttons are remained their position.

[5.Reproduction build]: 
Flame 2.2 build: affected
uild ID               20150312002501
Gaia Revision          572d60e0a440ee4af50bc6b6adad8876eadbdb4d
Gaia Date              2015-03-12 01:29:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/244e6ba3c20e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.040315
Firmware Date          Thu Mar 12 04:03:26 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build: affected
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.194521
Firmware Date          Thu Mar 12 19:45:32 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15449
QA Whiteboard: [rtl-impact]
Nominating: primary action (OK) should be left, secondary (Cancel) on the right for RTL.
blocking-b2g: --- → 2.2?
Whiteboard: [systemsfe]
Priority: -- → P2
Assignee: nobody → apastor
In all the FTU screens, the 'Next' button is on the right, so I'm not sure if the SIM screen should be different. Asking for UX input. Francis, should we swap those buttons? Thanks!
Flags: needinfo?(fdjabri)
Alberto, see bug 1037755. As the back/next are directional (spacial model) vs primary/secondary the decision for 2.2 was to keep the next/back buttons the same in LRT and RTL. Is was compromise as we didn't have time to fix all directionality in all navigation across Gaia.
Flags: needinfo?(fdjabri)
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15449/
Flags: in-moztrap+
Thanks for the info, Sam! Does that mean that the SIM PIN screen should be treated as directional and this bug is invalid, or is an exception in the FTU process? Thanks!
Flags: needinfo?(sfoster)
(In reply to Alberto Pastor [:albertopq] from comment #5)
> Thanks for the info, Sam! Does that mean that the SIM PIN screen should be
> treated as directional and this bug is invalid, or is an exception in the
> FTU process? Thanks!

The [ok] [cancel] buttons are not considered directional, so they should follow the primary/secondary arrangement and be [OK] [Cancel] in RTL. I know its a bit weird in this case as that screen forms part of a sequence in this context, but thats how the spec has it https://mozilla.app.box.com/s/bcm3s5i2v6js5uk0ws3tsywse8bgncgo (see Buttons and Dialogs section)
Flags: needinfo?(sfoster)
blocking-b2g: 2.2? → 2.2+
Can you confirm Comment #6 Stephanie, it raised questions as in the context of the FTU, the 'next' button does not get flipped and it may be a bit odd to have this inconsistency.
Flags: needinfo?(swilkes)
As noted in the spec, FTU is out of scope for 2.2.
Flags: needinfo?(swilkes)
Lancy: please make sure your test case reflects comment 8. 
When reviewing the FTE TCs, they all reflected the spec correctly. Please make sure this is still the case (ie not RTLing buttons in RTL FTE for 2.2)
Flags: needinfo?(yulan.zhu)
Delphine,

As you said, no buttons should be swapped during FTE, we will execute testing base on it and update the test case.
Thanks a lot.

Note: Invalid issue, and remove the flag of in-moztrap +
Flags: needinfo?(yulan.zhu)
Flags: in-moztrap+
Resolving as invalid, then. Thanks!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.