1142924 - [RTL][Message]The "+" symbol is shown at right side of the numeral (service center number) in SIM settings view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Lancy(Leave from Mozilla)]

[1.Description]:
[RTL][v2.2&v3.0][Message]The "+" symbol is shown at right side of the service center number in SIM settings view.
See attachment:SIM settings.png

[2.Testing Steps]: 
1.Insert two sim cards in device and set your phone language to Arabic.
2.Launch Message and tap settings in menu.
3.Select SIM 1/SIM2 under "SIM Settings" item.
4.Observe the view.

[3.Expected Result]: 
4.The "+" symbol should be shown at left side of the service center number.

[4.Actual Result]: 
4.The "+" symbol is shown at right side of the service center number in SIM settings view.

[5.Reproduction build]: 
Flame 2.2 build(Affected):
Build ID               20150312002501
Gaia Revision          572d60e0a440ee4af50bc6b6adad8876eadbdb4d
Gaia Date              2015-03-12 01:29:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/244e6ba3c20e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.040315
Firmware Date          Thu Mar 12 04:03:26 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build(Affected):
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.194521
Firmware Date          Thu Mar 12 19:45:32 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15406

Comment 1

[Lancy(Leave from Mozilla)]

Attachment: SIM settings.png

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Nominating: this is giving the wrong information to RTL users

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I can help this bug.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1142924 > mozilla-b2g:master

Comment 5

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15406/

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8577858 [details] [review]
[gaia] EragonJ:bug-1142924 > mozilla-b2g:master

Arthur, can you help me check this simple patch ? Thanks :)

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8577858 [details] [review]
[gaia] EragonJ:bug-1142924 > mozilla-b2g:master

As we insert a bdi element in some cases, we should clear the element for displaying smsc. r=me with this fixed, thanks!

Comment 9

[howie [:howie]]

Blocking

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch is merged at Gaia/master : https://github.com/mozilla-b2g/gaia/commit/eef9d5d746c61acef31fe1bfd6a228e510a81abb

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8577858 [details] [review]
[gaia] EragonJ:bug-1142924 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: the "+" symbol is shown at wrong direction
[Testing completed]: with manual tests
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 12

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the latest Night Flame 3.0 build.

Actual Results: The  + is on the correct side for both SIM 1 and SIM 2 settings menus.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150318055750
Gaia: b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39
Gecko: 41a61514461e
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/a3ef5b1a792957c8b22bb3cdded97f21e5a8cc88

Comment 14

[Sue]

Attachment: v2.2_verify_pass.png

This issue has been verified successfully on latest build of Flame 2.2 with the same steps in comment 0.
See attachment:v2.2_verify_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150406002503
Gaia Revision          a6351e1197d54f8624523c2db9ba1418f2aa046f
Gaia Date              2015-04-03 22:06:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c3335a5d3063
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150406.040047
Firmware Date          Mon Apr  6 04:00:58 EDT 2015
Bootloader             L1TC000118D0