Green up R6 and tc-R6 Linux Mulet reftests

RESOLVED FIXED in Firefox 39

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

unspecified
2.2 S8 (20mar)
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment, 2 obsolete attachments)

+++ This bug was initially created as a clone of Bug #1094369 +++

As visible on https://treeherder.allizom.org/#/jobs?repo=try&revision=f41c2814b753&exclusion_profile=false

REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/1090168-3.html | image comparison (==), max difference: 255, number of differing pixels: 64 

This test is expected to be fuzzy on B2G:
> fuzzy-if(B2G,244,173) == 1090168-3.html 1090168-3-ref.html

The difference reported on reftest analyzer is on the position of the 'e' char: http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/alissy@mozilla.com-f41c2814b753/try-linux64-mulet/try_ubuntu64_vm-mulet_test-reftest-6-bm116-tests1-linux64-build127.txt.gz&only_show_unexpected=1

Should we investigate a legit font issue or just make it fuzzy for Mulet too?
Flags: needinfo?(jfkthame)
Comment on attachment 8577175 [details] [diff] [review]
Make 1090168-3.html fuzzy on Mulet as on B2G r=jfkthame

Review of attachment 8577175 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/writing-mode/reftest.list
@@ +17,5 @@
>  == 1090159-1.html 1090159-1-ref.html
>  == 1090168-1.html 1090168-1-ref.html
>  != 1090168-1.html 1090168-1-notref.html
>  == 1090168-2.html 1090168-2-ref.html
> +fuzzy-if(B2G,244,173||Mulet,244,173) == 1090168-3.html 1090168-3-ref.html # bug 1142928: mark fuzzy on Mulet as on B2G

I'm OK with marking this fuzzy on mulet, but I don't think this patch will work as written. The mulet run apparently had a max difference of 255, so the numbers need fixing; but also I don't think you can use || like that in the fuzzy-if annotation. || is used within the condition, not (AFAIK) to introduce a whole new (condition,max-diff,num-pix) triplet. When we need different amounts of "fuzz" on different platforms, we normally do this with multiple fuzzy-if(...) annotations.

With the annotation here, I believe reftest.js will parse the entire string "B2G,244,173||Mulet" as being the condition; I don't know exactly how that will be evaluated but it's not what we want, and if the fuzz numbers are different it won't be using the intended ones.

A quick check with grep indicates this error is already present in a few cases, at least in layout/reftests/svg/reftest.list; this comes from bug 1138442. Please fix it there, too.
Flags: needinfo?(jfkthame)
Assignee

Comment 4

4 years ago
No wonder it's in bug 1138442, since I made the same error there. Thanks for finding.
Assignee

Updated

4 years ago
Attachment #8577175 - Attachment is obsolete: true
Assignee

Updated

4 years ago
Attachment #8577195 - Flags: review?(jfkthame)
Assignee

Comment 11

4 years ago
Comment on attachment 8577195 [details] [diff] [review]
Make 1090168-3.html fuzzy on Mulet as on B2G r=jfkthame

Failing differently on taskcluster:
> REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/build/tests/reftest/tests/layout/reftests/writing-mode/1090168-3.html | image comparison (==), max difference: 248, number of differing pixels: 165 

But the reftest analyzer shows mostly the same differences.
Attachment #8577195 - Flags: review?(jfkthame)
Assignee

Updated

4 years ago
Attachment #8577195 - Attachment is obsolete: true
Assignee

Updated

4 years ago
Summary: Green up R6 Linux Mulet reftests → Green up R6 and tc-R6 Linux Mulet reftests
Assignee

Updated

4 years ago
Attachment #8577214 - Flags: review?(jfkthame)
Attachment #8577214 - Flags: review?(jfkthame) → review+
Assignee

Updated

4 years ago
Keywords: checkin-needed
Assignee

Updated

4 years ago
Blocks: 1094369
No longer blocks: 1043699
https://hg.mozilla.org/mozilla-central/rev/781b06b48e02
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S8 (20mar)
You need to log in before you can comment on or make changes to this bug.