Closed
Bug 1142950
Opened 9 years ago
Closed 9 years ago
Update Loop's vendor libraries for unit tests
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox39 fixed)
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
186.96 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
For bug 1141133 I want to start experimenting with using chai-as-promised. In its deps it lists chai 2.0.0 as a minimum value and we're on 1.9.0. It won't hurt just to update our other test vendor libraries at the same time - I've tested them and there's no changes to the test code required, just a configuration change for chai.
|
Assignee | |
Updated•9 years ago
|
Summary: Update Loops vendor libraries for unit tests → Update Loop's vendor libraries for unit tests
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8577196 -
Flags: review?(mdeboer)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8577196 [details] [diff] [review] Update the vendor libraries Review of attachment 8577196 [details] [diff] [review]: ----------------------------------------------------------------- grmbl, ugly code in our tree, grmbl. Oh well, that ship has sailed, hasn't it? I think chai is horrible, contrived, hardly intuitive to use and lastly, verbose to the point of silly. I'm not going to review the code changes in the respective libraries. The other changes LGTM.
Attachment #8577196 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/dd49362ccaab
Target Milestone: --- → mozilla39
|
||
Updated•9 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
|
|
Assignee | |
Updated•9 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•