1142953 - update Brotli decompressor for WOFF2 to latest upstream revision

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

It looks like there are only very minor tweaks to the code, but it would be good to have the most up-to-date version in preparation for enabling WOFF2 on release channels.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Update Brotli decompressor to latest upstream revision; now at 8c9c83426beb4a58da34be76ea1fccb4054c4703

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Update Brotli decompressor to latest upstream revision; now at 8c9c83426beb4a58da34be76ea1fccb4054c4703

Brotli upstream has move from Google code to GitHub, so we should follow in order to pick up the currently-maintained code; regenerated the update accordingly.

Comment 3

[Jonathan Kew [:jfkthame]]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> Update Brotli decompressor to latest upstream revision; now at
> 8c9c83426beb4a58da34be76ea1fccb4054c4703

...and I've corrected the commit message locally to reflect the new upstream commit ID (as recorded in the README.mozilla file, too).

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46f600c2366b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46f600c2366b

Comment 6

[Frédéric Wang (:fredw)]

@Jonathan: So here is the workaround proposed to be able to use std::unique_ptr. It seems that we'll have to patch the woff2 source anyway... What do you think?

> ---------- Forwarded message ----------
> From: Lee Salzman <[e-mail]>
> Date: Mon, Feb 1, 2016 at 11:44 AM
> Subject: Re: Use of C++11 std::unique_ptr for the WOFF2 module
> To: Jeff Muizelaar <[e-mail]>
> 
> 
> The solution looks something like this (beware that it is indeed hacky):
> 
> #include <memory> // must be included first so that we don't interfere with pre-existing unique_ptr implementation
> #include "mozilla/UniquePtr.h"
> namespace std
> {
>   using mozilla::DefaultDelete;
>   using mozilla::UniquePtr;
>   #define default_delete DefaultDelete
>   #define unique_ptr UniquePtr
> }
> 
> An important feature of this workaround is that both the actual unique_ptr and UniquePtr will happily coexist in the same std namespace, but it will pollute the global namespace a bit because of the #defines. It works, though.