1142975 - crash in mozilla::gl::GLContext::IsOffscreenSizeAllowed(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&)

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ada [:adalucinet]]

This bug was filed from the Socorro interface and is 
report bp-fbb1b584-b1bc-4c96-90f9-41d9a2150313.
=============================================================

*2-time occurrence* - Encountered on Fx 37 beta 5 (Build ID: 20150312193711) under Windows 7 64-bit while loading WebGL content in several tabs - Eg:
http://www.3dsitelinks.com/webgl-games/
http://dl.dropboxusercontent.com/u/6983010/wserv/gexp_pulpo/index.html
http://davidwalsh.name/webgl-demos

Graphics
Adapter Description	NVIDIA GeForce 210
Adapter Drivers	nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Adapter RAM	1024
Device ID	0x0a65
Direct2D Enabled	true
DirectWrite Enabled	true (6.2.9200.16492)
Driver Date	5-19-2014
Driver Version	9.18.13.3788
GPU #2 Active	false
GPU Accelerated Windows	1/1 Direct3D 11 (OMTC)
Subsys ID	040110b0
Vendor ID	0x10de
WebGL Renderer	Google Inc. -- ANGLE (NVIDIA GeForce 210 Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote	true
AzureCanvasBackend	direct2d 1.1
AzureContentBackend	direct2d 1.1
AzureFallbackCanvasBackend	cairo
AzureSkiaAccelerated	0

Comment 1

[Nicolas Silva [:nical]]

The WebGLContext::gl got nulled out in ForceLoseContext which was called by PresentScreenBuffer just before SetDimensions.

Looks like a null pointer check in ResizeBackBuffer should do.

Comment 2

[Nicolas Silva [:nical]]

Attachment: null check

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Check-for-Present-caused-context-loss.patch

I think it's best to handle this at the callsite, since Resize isn't a valid operation for a lost context.

Thanks for the investigation!

Comment 4

[Kelsey Gilbert [:jgilbert]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/b3589228e8b1

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c9883ca6b8c4 for gl test failures:

https://treeherder.mozilla.org/logviewer.html#?job_id=7683288&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=7684199&repo=mozilla-inbound

Comment 6

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc2ae042cf01

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc2ae042cf01

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Socorro [1] shows no crashes on Firefox 39 over the past 4 weeks.

[1] - https://crash-stats.mozilla.com/report/list?range_unit=days&range_value=28&signature=mozilla%3A%3Agl%3A%3AGLContext%3A%3AIsOffscreenSizeAllowed%28mozilla%3A%3Agfx%3A%3AIntSizeTyped%3Cmozilla%3A%3Agfx%3A%3AUnknownUnits%3E+const%26%29