Closed Bug 1142975 Opened 6 years ago Closed 6 years ago

crash in mozilla::gl::GLContext::IsOffscreenSizeAllowed(mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits> const&)

Categories

(Core :: Canvas: WebGL, defect)

37 Branch
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla39
Tracking Status
firefox39 --- verified

People

(Reporter: adalucinet, Assigned: nical)

Details

(Keywords: crash, Whiteboard: [gfx-noted])

Crash Data

Attachments

(1 file, 1 obsolete file)

This bug was filed from the Socorro interface and is 
report bp-fbb1b584-b1bc-4c96-90f9-41d9a2150313.
=============================================================

*2-time occurrence* - Encountered on Fx 37 beta 5 (Build ID: 20150312193711) under Windows 7 64-bit while loading WebGL content in several tabs - Eg:
http://www.3dsitelinks.com/webgl-games/
http://dl.dropboxusercontent.com/u/6983010/wserv/gexp_pulpo/index.html
http://davidwalsh.name/webgl-demos

Graphics
Adapter Description	NVIDIA GeForce 210
Adapter Drivers	nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um
Adapter RAM	1024
Device ID	0x0a65
Direct2D Enabled	true
DirectWrite Enabled	true (6.2.9200.16492)
Driver Date	5-19-2014
Driver Version	9.18.13.3788
GPU #2 Active	false
GPU Accelerated Windows	1/1 Direct3D 11 (OMTC)
Subsys ID	040110b0
Vendor ID	0x10de
WebGL Renderer	Google Inc. -- ANGLE (NVIDIA GeForce 210 Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote	true
AzureCanvasBackend	direct2d 1.1
AzureContentBackend	direct2d 1.1
AzureFallbackCanvasBackend	cairo
AzureSkiaAccelerated	0
The WebGLContext::gl got nulled out in ForceLoseContext which was called by PresentScreenBuffer just before SetDimensions.

Looks like a null pointer check in ResizeBackBuffer should do.
QA Contact: nical.bugzilla
Whiteboard: [gfx-noted]
Assignee: nobody → nical.bugzilla
QA Contact: nical.bugzilla
Attached patch null check (obsolete) — Splinter Review
Attachment #8578084 - Flags: review?(jgilbert)
I think it's best to handle this at the callsite, since Resize isn't a valid operation for a lost context.

Thanks for the investigation!
Attachment #8578084 - Attachment is obsolete: true
Attachment #8578084 - Flags: review?(jgilbert)
Attachment #8578179 - Flags: review?(dglastonbury)
Attachment #8578179 - Flags: review?(dglastonbury) → review+
OS: Windows NT → All
Hardware: x86 → All
Flags: needinfo?(nical.bugzilla)
https://hg.mozilla.org/mozilla-central/rev/cc2ae042cf01
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.