1142989 - [e10s] Re-enable some bookmarks related tests

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Neil Deakin]

Attachment: Enable tests

These eight tests seem to work fine.

 browser_475045.js
 browser_410196_paste_into_tags.js
 browser_history_sidebar_search.js
 browser_bookmarksProperties.js
 browser_555547.js
 browser_416459_cut.js
 browser_435851_copy_query.js
 browser_toolbarbutton_menu_context.js


Let's re-enable them.

Comment 1

[Neil Deakin]

Passing:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e66422af62af
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4fffb561870

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8577242 [details] [diff] [review]
Enable tests

Review of attachment 8577242 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/tests/browser/browser.ini
@@ -23,5 @@
>  [browser_library_open_leak.js]
>  [browser_library_panel_leak.js]
>  [browser_library_search.js]
>  [browser_history_sidebar_search.js]
> -skip-if = e10s && (os == 'linux' || os == 'mac') # Bug 1116457

bug 1116457 is still open and was disabled not much time ago, I'm not very confident about re-enabling it., unless you figured that another bug solved the issues we were hitting here.

Comment 3

[Neil Deakin]

(In reply to Marco Bonardo [::mak] from comment #2)
> Comment on attachment 8577242 [details] [diff] [review]
> Enable tests
> 
> Review of attachment 8577242 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/components/places/tests/browser/browser.ini
> @@ -23,5 @@
> >  [browser_library_open_leak.js]
> >  [browser_library_panel_leak.js]
> >  [browser_library_search.js]
> >  [browser_history_sidebar_search.js]
> > -skip-if = e10s && (os == 'linux' || os == 'mac') # Bug 1116457
> 
> bug 1116457 is still open and was disabled not much time ago, I'm not very
> confident about re-enabling it., unless you figured that another bug solved
> the issues we were hitting here.

Ah, I meant to leave that one as is.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8577242 [details] [diff] [review]
Enable tests

Review of attachment 8577242 [details] [diff] [review]:
-----------------------------------------------------------------

ok, r=me if you leave that test alone.

Comment 5

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b00b7748955

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b00b7748955