1142991 - Update manifest to use B2G's QEMU kernel on emulator l

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The kernel recently landed in bug 1135017. We should update the manifest accordingly.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Comment 2

[(PTO June 19-July 7) Ryan VanderMeulen]

Can we run this through Try too? Editing the in-tree sources.xml manually to point at rev 2c0d193349c55337e37196a7f2d5cef37753ed3e should work:
http://mxr.mozilla.org/mozilla-central/source/b2g/config/emulator-l/sources.xml#127

Thanks :)

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Sure!

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

But it won't build or run anything, just checkout the tree.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

As discussed on IRC, testing on try isn't worth the effort for prebuilt binaries.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

Merged into master:
https://github.com/mozilla-b2g/b2g-manifest/commit/a2d1c578de099c2480ac4209b101dbe183251331

I think we also need this in v2.2 branch. Would you send a PR to v2.2 branch? Thanks!

Comment 8

[(PTO June 19-July 7) Ryan VanderMeulen]

Reverted for Nexus 5-L bustage.
https://github.com/mozilla-b2g/b2g-manifest/commit/564ed022a32c721a71d614fd7bc6c0c2c1dd807e

https://treeherder.mozilla.org/logviewer.html#?job_id=1521225&repo=b2g-inbound

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

Thomas, 

Could you add 'remove-project' in emulator-l.xml and not remove nothing in base-l.xml? Thanks!

such as:
<remove-project name="platform/prebuilts/qemu-kernel">
<project name="platform_prebuilts_qemu-kernel" path="prebuilts/qemu-kernel" remote="b2g" revision="b2g-5.0.0_r6"/>

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I removed the prebuilt kernels in base-l.xml, so that non-emulator platforms wouldn't clone them. If this doesn't work, we can also leave the project in base-l.xml.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I updated my local branch on Github and pushed a test to try.

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e1fc5cde6b2

Comment 12

[bhavana bajaj [:bajaj]]

I would not block on this technically but happy to uplift this change once fixed on master, so feel free to seek approval.

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Another try

  https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fd3d0f7fc5f

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Try looks good this time.

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8579208 [details] [review]
Github pull request

I also try, nexus-5-l build is also good.

Comment 16

[Kai-Zhen Li [:seinlin][:kli]]

Master: https://github.com/mozilla-b2g/b2g-manifest/commit/b09e1906688d09caed69897ba36b419ec76c41bc
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/214f81826bab8e5936b6b54151fc89e77e2b8647

Comment 17

[Kai-Zhen Li [:seinlin][:kli]]

emulator-l/emulator-x86-l also use base-l.xml, pick the changes into emulator-l.xml too.
v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/4acb52daf765b4203a625946f629cd59fb368611