Closed
Bug 1143010
Opened 9 years ago
Closed 9 years ago
Stopping a mochitest-browser run is rocket science
Categories
(Testing :: Mochitest, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: jmaher)
References
Details
Attachments
(1 file)
1.22 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
See problem description at https://groups.google.com/d/msg/mozilla.dev.platform/LW0EcQUGD_I/JrdXoshzlRoJ Ted pointed out that this is because of the per-directory restarts.
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8578006 [details] [diff] [review] return from a loop when we have forced the run to quit (1.0) Review of attachment 8578006 [details] [diff] [review]: ----------------------------------------------------------------- Such a simple fix! ::: testing/mochitest/runtests.py @@ +2060,5 @@ > # Dump the logging buffer > self.message_logger.dump_buffered() > > + if result == -1: > + break So -1 is what we return for KeyboardInterrupt, which ought to fix this bug. Do we need to handle any other cases here?
Attachment #8578006 -
Flags: review?(ted) → review+
Assignee | ||
Comment 4•9 years ago
|
||
-1 is the status returned for keyboard interrupt as well as other failures (crash, etc.) and many other 'done' status things inside the inner loop.
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65e0f86c9c42
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65e0f86c9c42
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•6 years ago
|
Component: BrowserTest → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•