Closed Bug 1143025 Opened 9 years ago Closed 9 years ago

NS_ERROR_ILLEGAL_VALUE calling nukeSandbox in mochitest-jetpack tests

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
evold
: review+
Details | Review
Seems to show up after every add-on test, something is throwing when trying to nuke the sandboxes. Doesn't seem to be breaking things though.
Priority: -- → P1
Looks like this was introduced by bug 1037235
Assignee: nobody → dtownsend
Depends on: 1037235
Attached file pull request
Simple fix
Attachment #8578988 - Flags: review?(evold)
Comment on attachment 8578988 [details] [review]
pull request

Ah this was my bad, thanks!
Attachment #8578988 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/69a304f1a665eb457cc65874384f547701e52b9c
Bug 1143025: xulappSandbox no longer exists so don't try to unload it.

https://github.com/mozilla/addon-sdk/commit/71d8f2ba6aaf3aa98fdf68e4579ff47e2bcf1431
Merge pull request #1902 from Mossop/bug1143025

Bug 1143025: xulappSandbox no longer exists so don't try to unload it. r=erikvold
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: