Closed Bug 1143027 Opened 9 years ago Closed 9 years ago

When recording a profile, a recording icon should be in the Performance tab

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(2 files, 1 obsolete file)

Maybe only when on a different tab than Performance, like the debugger when it's paused, but this would be useful when you have the console open, and a profile/profileEnd cycle is called so the user knows the performance tool is recording something.
Assignee: nobody → jsantell
Blocks: perf-tool-v2
Not specifically blocking v2.
No longer blocks: perf-tool-v2
Blocks: perf-tool-v2
Depends on: 1077464
(got a patch for this for v2)
Blocks: perf-tool-papercuts
No longer blocks: perf-tool-v2
No longer blocks: perf-polish
Status: NEW → ASSIGNED
Attached image highlighter.gif
This looks cool.
Comment on attachment 8598311 [details] [diff] [review]
1143027-perf-highlight.patch

Review of attachment 8598311 [details] [diff] [review]:
-----------------------------------------------------------------

Loving it.

::: browser/devtools/performance/modules/front.js
@@ +37,5 @@
>  // Events to pipe from PerformanceActorsConnection to the PerformanceFront
>  const CONNECTION_PIPE_EVENTS = [
>    "console-profile-start", "console-profile-ending", "console-profile-end",
> +  "timeline-data", "profiler-already-active", "profiler-activated", "recording-started",
> +  "recording-stopped"

Nit: recording-started and recording-stopped would be more readable on their own line.

::: browser/devtools/performance/panel.js
@@ +33,5 @@
>     */
>    open: Task.async(function*() {
>      this.panelWin.gToolbox = this._toolbox;
>      this.panelWin.gTarget = this.target;
> +    this._onRecordingStartAndStop = this._onRecordingStartAndStop.bind(this);

Nit: or, not and.
Attachment #8598311 - Flags: review?(vporof) → review+
nits fixed
Attachment #8598311 - Attachment is obsolete: true
Attachment #8598999 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/285639a4d08c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.