1143028 - Opening WebIDE logs TypeError: this.connection is null app-manager.js:435:4

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Seeing this on Nightly (Mac and Linux) every time I open WebIDE. I don't remember seeing this a while ago, but I'm not sure when it started.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I think this is breaking Valence. I can't connect to desktop Chrome with Nightly, but DevEdition works fine, for the same version of Valence.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1126432 is sharing and reusing app-manager.js in ways it was not expecting.

We'll need to change a few things to ensure it's always init()ed properly.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1143028-Make-AppMan-reinitable-update-tab-list-w.patch

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b2fb1f84fc9

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8577361 [details] [diff] [review]
0001-Bug-1143028-Make-AppMan-reinitable-update-tab-list-w.patch

Only one review needed, whoever wants to grab it!

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8577361 [details] [diff] [review]
0001-Bug-1143028-Make-AppMan-reinitable-update-tab-list-w.patch

Review of attachment 8577361 [details] [diff] [review]:
-----------------------------------------------------------------

I'm taking it so that Alex can concentrate on reviewing my patch :)

::: browser/devtools/webide/modules/app-manager.js
@@ +37,5 @@
>    init: function() {
> +    if (this._initialized) {
> +      return;
> +    }
> +    this._initialized = true;

Define _initialized and _uninitialized outside of init/uninit to ensure AppManager doesn't get deoptimized by the JIT to dictionary mode.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Panos Astithas [:past] from comment #6)
> Define _initialized and _uninitialized outside of init/uninit to ensure
> AppManager doesn't get deoptimized by the JIT to dictionary mode.

Okay, fixed!

Turns out that using separate flags is a terrible idea, since this module is a singleton that gets re-inited later.  So, I've also condensed to one flag.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=813f909c8a1b

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: 0001-Bug-1143028-Make-AppMan-reinitable-update-tab-list-w.patch

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e687d9ffd8a9

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e687d9ffd8a9