1143077 - Add assignment operators for mozilla::Pair

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Now that mozilla::Pair supports copying and moving, we should make it support assignment operators too.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Add assignment operators to mozilla::Pair

Here's the patch. Trivial, except that again due to MSVC 2013 we can't use "= default" for the move assignment operator.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8577531 [details] [diff] [review]
Add assignment operators to mozilla::Pair

Review of attachment 8577531 [details] [diff] [review]:
-----------------------------------------------------------------

Worth adding an assignment to the test file just to exercise this at least a little.

::: mfbt/Pair.h
@@ +167,5 @@
>    Pair(const Pair& aOther) = default;
>  
> +  Pair& operator=(Pair&& aOther)
> +  {
> +    MOZ_ASSERT(this != &aOther, "Self-moves are prohibited");

More common to not capitalize the first letter of an assertion, I think.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/14e7f9959c85

I'll push a followup to update the test.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Attachment: (Followup) - Add assignments to Pair test

Here's that followup. I can't push it right now because inbound is down.

Comment 5

[Seth Fowler [:seth] [:s2h]]

Pushed that followup:

https://hg.mozilla.org/integration/mozilla-inbound/rev/098d9685e26f

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/14e7f9959c85
https://hg.mozilla.org/mozilla-central/rev/098d9685e26f