1143090 - Enable recording Telemetry locally for mochitests and disable its submission

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Andrew Overholt [:overholt]]

I am writing a Telemetry probe and would like to be able to verify it is collected properly in a mochitest.  After some headscratching and discussion with Vladan, it appears we don't have Telemetry enabled while running mochitests; it would be nice if we did.

Comment 1

[Mark Reid [:mreid]]

We don't want to submit this telemetry data to the server, though, right?

Comment 2

[Nathan Froyd [:froydnj]]

I was just trying to write a mochitest for verifying telemetry and probably would have been very confused by things not being counted, so this is a timely bug.

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Mark Reid [:mreid] from comment #1)
> We don't want to submit this telemetry data to the server, though, right?

Correct (IMO).

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Andrew, Vladan asked me to help with this if you have any question. How urgent is that work?

Comment 5

[Andrew Overholt [:overholt]]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #4)
> Andrew, Vladan asked me to help with this if you have any question. How
> urgent is that work?

Oh, it's not.  I'll land my probe without a test as it seems that's what's normally done :)  But I'll watch here and add a test when this is ready.  Thanks!

Comment 6

[David Teller [:Yoric] - still alive but not very active]

In the meantime, I believe that the following snippet is sufficient:

  let oldCanRecord = Services.telemetry.canRecord;
  Services.telemetry.canRecord = true;
  registerCleanupFunction(() => {
    Services.telemetry.canRecord = oldCanRecord;
  });

That's what I use in my test code that needs to play with Telemetry.

Comment 7

[Chris H-C :chutten]

We already disable submission on non-official builds, and mochitests can enable telemetry collection.