1143091 - restarting tests with --keep-open is hard

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Nathan Froyd [:froydnj]]

I'm writing a new browser-chrome mochitest, and I got tired of waiting for the harness to start up every time.  I thought I would be clever and run:

  mach mochitest-browser --keep-open $TEST

and then click the "run $DIR tests" button in the browser window that pops open.

Turns out that doesn't work; I get:

TEST-UNEXPECTED-FAIL: setup.js | error parsing http://mochi.test:8888/tests.json (TypeError: redeclaration of const KEYBOARD_LAYOUT_ARABIC)
JavaScript error: chrome://mochikit/content/tests/SimpleTest/EventUtils.js, line 646: TypeError: redeclaration of const KEYBOARD_LAYOUT_ARABIC

when clicking the button.

I can fix all of the |const| issues in EventUtils.js, but I'm wondering if a) the above was the wrong way to do things; or b) if there's a better way to fix things so that they work as expected?  (c, making this testable so it doesn't regress, would be even better!)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We should support this use case, though it risks frequently running into "tests don't clean up fully" or "tests depend on a clean application slate" issues.

To do this cleanly we probably want to update runTests() in browser-harness.xul to be smarter about its second invocation - e.g. it should not re-generate the test list. Maybe that's as easy as just having it cache the Tester() object it creates via createTester() rather than always re-creating one.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: bare minimum fix to reset the state between tests (1.0)

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e61d6f1841dc

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e61d6f1841dc