1143140 - Don't pseudolocalize HTML entities

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
With language set to Runtime Accented, the string "Multimedia Messaging (MMS)" in Messaging Settings has visible unicode character codes at beginning and end of string. At the beginning is the character ‪ (left to right embedding) and at the end is ‬ (pop directional formatting).

This issue also appears when language is set to Runtime Mirrored.

Repro Steps:
1) Update a Flame to 20150313010238
2) Set language to Runtime Accented
3) Navigate to Settings > Messaging Settings

Actual:
String "Multimedia Messaging (MMS)" has visible unicode character codes at each end.

Expected:
No unicode character codes visible.

Environmental Variables:
Device: Flame 3.0
Build ID: 20150313010238
Gaia: eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gecko: 42afc7ef5ccb
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Brogan Zumwalt [Inactive]]

Issue DOES reproduce in Flame 2.2

String "Multimedia Messaging (MMS)" has visible unicode character codes at each end.

Device: Flame 2.2
Build ID: 20150313002507
Gaia: 4aefc3f6f30a40ac67fdf841b7c90cd648b85369
Gecko: 049713f3b0ed
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Issue does NOT reproduce on Flame 2.1

No unicode character codes visible.

Device: Flame 2.1
Build ID: 20150313001220
Gaia: 90f4ca618048b608c8e663d3e1d84781cfa719a8
Gecko: b5e84199ea73
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Delphine, can you weigh in on the severity of this issue? It is a regression.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

I really don't know about the severity :) this seems to be a bug within pseudlocales, that happens because you can see this code in the string, but localizers know they shouldn't translate it. However pseudlocales probably doesn't detect this as something that should *not* be localized.
Adding :stas and :gandalf so they can weigh in on this. 
Let's wait for them to answer before filing other instances where this happens, so we know how to go forwards on this. thanks!

Comment 4

[Staś Małolepszy :stas]

This is indeed a bug in pseudolocales related to bug 1137094, although I might be able to fix this in a simpler way, too.  I'll have a look.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] stasm:1143140-pseudol10n-exclude-html-entities > mozilla-b2g:master

Comment 6

[Staś Małolepszy :stas]

Master: https://github.com/mozilla-b2g/gaia/commit/4868c56c0a3b7a1e51d55b24457e44a7709ea1ae
L20n: https://github.com/l20n/l20n.js/commit/868dfaa66ef3780b645e54cf5248ded539d59694