Rename icaljs/libical manifest files to fool the packager

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Build Config
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
4.0.0.1

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
The packager considers any .manifest file that is not referenced to be a new base directory. In combination with bug 910660's patch, we can work around by renaming the .manifest file to something that doesn't end with .manfest.
(Assignee)

Comment 1

2 years ago
Pushed to comm-central changeset 88c91b465fa8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
(Assignee)

Comment 2

2 years ago
Created attachment 8577458 [details]
MozReview Request: bz://1143163/Fallen

/r/5395 - Fix bug 1143163 - Rename icaljs/libical manifest files to fool the packager. r=MakeMyDay

Pull down this commit:

hg pull review -r 88c91b465fa821959fa3798aaeed6964685b0d96
Attachment #8577458 - Flags: review?(makemyday)
(Assignee)

Comment 3

2 years ago
Please ignore comment 1, this was just a script error. Its not actually pushed to c-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/5395/#review4339

Comment 5

2 years ago
https://reviewboard.mozilla.org/r/5395/#review4341

Looks good, r=MakeMyDay
(Assignee)

Comment 6

2 years ago
https://reviewboard.mozilla.org/r/5395/#review4407

Ship It!
(Assignee)

Updated

2 years ago
Attachment #8577458 - Flags: review?(makemyday) → review+
(Assignee)

Comment 7

2 years ago
Reviewboard is more confusing than uploading patches.
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
Component: Build Config → Build Config
Product: Thunderbird → Calendar
Target Milestone: Thunderbird 39.0 → ---
Version: 30 → unspecified
(Assignee)

Updated

2 years ago
Attachment #8577458 - Flags: approval-calendar-aurora+
(Assignee)

Comment 8

2 years ago
Pushed to comm-central changeset 65c0e175a5da
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.1
(Assignee)

Comment 9

2 years ago
Backported to releases/comm-aurora changeset 2947dd6c9e50
Target Milestone: 4.1 → 4.0
(Assignee)

Comment 10

2 years ago
Comment on attachment 8577458 [details]
MozReview Request: bz://1143163/Fallen
Attachment #8577458 - Attachment is obsolete: true
Attachment #8619753 - Flags: review+
(Assignee)

Comment 11

2 years ago
Created attachment 8619753 [details]
MozReview Request: Fix bug 1143163 - Rename icaljs/libical manifest files to fool the packager. r=MakeMyDay
You need to log in before you can comment on or make changes to this bug.