1143163 - Rename icaljs/libical manifest files to fool the packager

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The packager considers any .manifest file that is not referenced to be a new base directory. In combination with bug 910660's patch, we can work around by renaming the .manifest file to something that doesn't end with .manfest.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 88c91b465fa8

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: MozReview Request: bz://1143163/Fallen

/r/5395 - Fix bug 1143163 - Rename icaljs/libical manifest files to fool the packager. r=MakeMyDay

Pull down this commit:

hg pull review -r 88c91b465fa821959fa3798aaeed6964685b0d96

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Please ignore comment 1, this was just a script error. Its not actually pushed to c-c.

Comment 4

[[:MakeMyDay]]

https://reviewboard.mozilla.org/r/5395/#review4339

Comment 5

[[:MakeMyDay]]

https://reviewboard.mozilla.org/r/5395/#review4341

Looks good, r=MakeMyDay

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://reviewboard.mozilla.org/r/5395/#review4407

Ship It!

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Reviewboard is more confusing than uploading patches.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 65c0e175a5da

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 2947dd6c9e50

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: MozReview Request: Fix bug 1143163 - Rename icaljs/libical manifest files to fool the packager. r=MakeMyDay