1143179 - "One Click Popup Dictionary" add-on can't find any word definitions (with or without e10s)

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Gabriela [:gaby2300]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Windows 7 64 bit, es-AR

With e10s disabled, it never finds any definition.
With e10s enabled the addon crahses all the tabs. No recover all tabs is possible.

Comment 1

[Chris Peterson [:cpeterson]]

Gabriela, do you about any crash IDs from about:crashes?

Comment 2

[Chris Peterson [:cpeterson]]

Gabriela, is the WordWeb add-on you are using? I can't find "WordWeb one-click lookup" on addons.mozilla.org. The WordWeb looks like it might be a binary add-on or a plugin.

Comment 3

[Gabriela [:gaby2300]]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> Gabriela, is the WordWeb add-on you are using? I can't find "WordWeb
> one-click lookup" on addons.mozilla.org. The WordWeb looks like it might be
> a binary add-on or a plugin.

Chris, I found "WordWeb one-click lookup" in http://arewee10syet.com/. Clicking on that site's link I got to https://addons.mozilla.org/en-us/firefox/addon/one-click-popup-dictionary/, which was the addon that I installed.  

With e10s disabled, it never found any definition.
With e10s enabled the addon crashed all the tabs. No recover all tabs was possible.
I have 6 crash IDs from about:crashes. I can paste them here if necessary.

Trying again with today's update, with e10s disabled, it never finds any definition. With e10s enabled it doesn't crash but it does not work either: clicking the addon button and/or pressing Shift+D the help window shows up but no definitions.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Gabriela [:gaby2300] from comment #3)
> Chris, I found "WordWeb one-click lookup" in http://arewee10syet.com/.
> Clicking on that site's link I got to
> https://addons.mozilla.org/en-us/firefox/addon/one-click-popup-dictionary/,
> which was the addon that I installed.  

Thanks, Gabriela. I updated the bug summary and arewee10syet.com to use the "One Click Popup Dictionary" addon name.


> With e10s disabled, it never found any definition.
> With e10s enabled the addon crashed all the tabs. No recover all tabs was
> possible.
> I have 6 crash IDs from about:crashes. I can paste them here if necessary.

If the latest Nightly update does not crash, then you don't need to paste the crash IDs here. We can assume that particular crash is fixed unless you see it again. :)


> Trying again with today's update, with e10s disabled, it never finds any
> definition. With e10s enabled it doesn't crash but it does not work either:
> clicking the addon button and/or pressing Shift+D the help window shows up
> but no definitions.

Does the addon find definitions in Firefox 36, the current release version of Firefox? I removed "e10s" from the bug summary because you said the addon doesn't find any word definitions regardless of whether e10s is enabled or disabled.

Comment 5

[Chris Peterson [:cpeterson]]

Rejah, Sreenath, and Prathapan, are you the developers of the "One Click Popup Dictionary" add-on?

The add-on seems to be broken in the Firefox Nightly channel and might be broken with multiprocess Firefox (e10s). If you have any questions about e10s support, just drop by the #e10s IRC channel on irc.mozilla.org or ask Jim Mathies on this bug. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Comment 6

[Gabriela [:gaby2300]]

(In reply to Chris Peterson [:cpeterson] from comment #4)

> Does the addon find definitions in Firefox 36, the current release version
> of Firefox? I removed "e10s" from the bug summary because you said the addon
> doesn't find any word definitions regardless of whether e10s is enabled or
> disabled.

No, it doesn't work in Firefox 36 either: "No definition found". I had to install an earlier version of the addon though, v 1.1 instead of the latest 1.2 because this one failed to install: "the addon couldn't be installed because it doesn't match the addon that Firefox expected". I had the same issue in Nightly.

Comment 7

[rejah.rehim]

I am working on it, will update soon

Comment 8

[Jim Mathies [:jimm]]

(In reply to rejah.rehim from comment #7)
> I am working on it, will update soon

Hey Rejah,

No need to mark this tracking-e10s unless you find a bug in the browser that is causing you trouble. We aren't tracking add-on specific issues using bugzilla's e10s flags.

Dropping this into the addons bug and marking +. Per the comments, in e10s, this addon currently crashes all tabs.

Comment 9

[rejah.rehim]

New version Updated with e10s support.

Comment 10

[Tracy Walker [:tracy]]

Gaby, does this addon work for you with updated version?

Comment 11

[Gabriela [:gaby2300]]

Tracy, yes! It works fine in Nightly now either with e10s enabled or disabled.