1143206 - [Private Browsing] Sheets displaying incorrect icon/text

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Eric Pang [:epang] UX]

Hi Kevin,

Francis and I tested this today but both saw different things.  Can you help check that the Private browsing (mask) icon shows up onto of the text? 

Also, can we reduce the font weight but one step?  It's looking a little heavy.

Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: 2015-03-13-23-01-42.png

here's what I saw when testing

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1143206_pb_identification_overlay > mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8577805 [details] [review]
[gaia] KevinGrandon:bug_1143206_pb_identification_overlay > mozilla-b2g:master

Etienne or Alive - could either of you review this for me?

The problem is that the private browsing app window is initially set to an app:// origin, then changes to a http:// origin when the user navigates somewhere. It's causing a few headaches, so in the future I think we might want to consider using static HTML in the system instead of an iframe for the landing page. Let me know what you think, thanks!

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8577805 [details] [review]
[gaia] KevinGrandon:bug_1143206_pb_identification_overlay > mozilla-b2g:master

r=me

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/891cdf0744f316c58fd8a1f42dd75a19fe2d4d7f

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8577805 [details] [review]
[gaia] KevinGrandon:bug_1143206_pb_identification_overlay > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Poor UX when using edge gestures + private browsing.
[Testing completed]: Manual and unit testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, small change to private browsing feature.
[String changes made]: None.

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 8577805 [details] [review]
[gaia] KevinGrandon:bug_1143206_pb_identification_overlay > mozilla-b2g:master

approving this low risk change given private browsing is new in 2.2

Comment 8

[Kevin Grandon :kgrandon]

(In reply to Eric Pang [:epang] from comment #0)
> Also, can we reduce the font weight but one step?  It's looking a little
> heavy.

Oops - the patch here missed that detail. I'm filing another follow-up bug for it and will block the meta bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c9240a194594b453b6b1522b0711767a9a45d3f7