Closed
Bug 1143219
Opened 9 years ago
Closed 9 years ago
Add tests for passing an unknown request to match and matchAll
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
5.37 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8577511 -
Flags: review?(bkelly)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: cachetests
Comment 2•9 years ago
|
||
Comment on attachment 8577511 [details] [diff] [review] Add tests for passing an unknown request to match and matchAll Review of attachment 8577511 [details] [diff] [review]: ----------------------------------------------------------------- LGTM with one additional check. I'm ok if its done in a later patch. Thanks. ::: dom/cache/test/mochitest/test_cache_match_request.js @@ +54,5 @@ > }).then(function() { > + return c.match(unknownRequest); > + }).then(function(r) { > + is(typeof r, "undefined", "Searching for an unknown request should not succeed"); > + return caches.match(unknownRequest); Can you check |caches.match(unknownRequest, {cacheName: name})| as well? It should be undefined, I believe.
Attachment #8577511 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Done: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b91bd12fb79
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0b91bd12fb79
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•