Closed Bug 1143255 Opened 11 years ago Closed 7 years ago

Replace <th-favicon-link></th-favicon-link> tag in index.html with something that is valid markup

Categories

(Tree Management :: Treeherder: Frontend, defect, P3)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

View source the TreeHerder page and look inside <head>. This template tag was added in bug 1042616.
That tag is actually used by: https://github.com/mozilla/treeherder-ui/blob/1d81a9ceb67518688711de30e7d5e4326896c59e/webapp/app/js/directives/main.js#L137 "But wait" I hear you say... "th-favicon-link" returns zero results when grepping the repo! Well Angular apparently normalises that to "thFaviconLink" - which is what the directive refers to. Really not helpful when trying to grep around the repo :-( https://docs.angularjs.org/guide/directive#normalization Too much magic and indirection in Angular IMO (or at least the way we use it)
Yeah I already deciphered all of that stuff, but when I said "untouched" I meant that the output of the template processor includes this tag. See the part about viewsourcing in comment 0.
Fwiw the same is true for <th-notification-box></th-notification-box>, farther down in viewsource.
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
See Also: → 1198037
See Also: 1198037 →
Summary: <th-favicon-link></th-favicon-link> element is left untouched by the template → Replace <th-favicon-link></th-favicon-link> tag in index.html with something that is valid markup
Component: Treeherder → Treeherder: Frontend
This was addressed by moving away from Angular to ReactJS. We've not removed the favicon directive in these commits: Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/5ed0ab98facd66f56b7c056251d4cb7b68974153 Bug 1482536 - Convert favicon to ReactJS https://github.com/mozilla/treeherder/commit/815901366f8b2070454a901340b2b99fc9dbeff3 Bug 1482536 - Stop using deprecated ``urlBasePath`` https://github.com/mozilla/treeherder/commit/a1dc384a9bfe074f403eaf402a3e79d9355234f4 Bug 1482536 - Convert Repository Model to ReactJS
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
<th-notification-box> will also be replaced shortly... :)
You need to log in before you can comment on or make changes to this bug.