This bug was filed from the Socorro interface and is report bp-a823a38a-239e-41d0-9325-1afc52150204. ============================================================= Just for follow ...
Crash Signature: [@ shutdownhang | RtlEnterCriticalSection | PR_Lock | mozilla::net::CacheFile::~CacheFile()] → [@ shutdownhang | RtlEnterCriticalSection | PR_Lock | mozilla::net::CacheFile::~CacheFile()] [@ shutdownhang | RtlEnterCriticalSection | PR_Lock | mozilla::net::CacheFile::~CacheFile]
honza, there are a few dozen of these in crash-stats.. but none more recent than 46. do you think it is fixed or just lack of data? if we think its open we probably ought to focus on it as this class of bug has gotten priority project wide
Michal, CacheFile is your area, can you check please?
Flags: needinfo?(honzab.moz) → needinfo?(michal.novotny)
Nothing is holding CacheFile's lock, so the main thread isn't blocked on the lock. It seems to me to be one of those crashes where we have many entries that we release during shutdown. Or is there any reason to believe it's not this case? It seems like there are another variants of the same problem, e.g. signature shutdownhang | msvcr120.dll@0x345ac | arena_dalloc_large | je_free | mozilla::net::CacheFileMetadata::~CacheFileMetadata. I hope these crashes were fixed with the recent changes in cache shutdown logic.
(In reply to Michal Novotny (:michal) from comment #3) > with the recent changes in cache shutdown logic. Can you refer bug#s?
too early to look at crash stats and make a judgment?
Assignee: nobody → michal.novotny
I guess this is a dupe of 1267980. Cache IO thread is idle and nothing is holding cache file's lock. The reason why releasing the cache entries is slow is probably the same as in bug 1267980, just small portion of those crashes aren't killed while poisoning the memory. I'll keep this bug open until we can verify this from crash stats.
I cannot find any crash for 48. It seems it was fixed by 1267980.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Crash volume for signature 'shutdownhang | RtlEnterCriticalSection | PR_Lock | mozilla::net::CacheFile::~CacheFile': - nightly (version 50): 0 crash from 2016-06-06. - aurora (version 49): 0 crash from 2016-06-07. - beta (version 48): 23 crashes from 2016-06-06. - release (version 47): 245 crashes from 2016-05-31. - esr (version 45): 23 crashes from 2016-04-07. Crash volume on the last weeks: Week N-1 Week N-2 Week N-3 Week N-4 Week N-5 Week N-6 Week N-7 - nightly 0 0 0 0 0 0 0 - aurora 0 0 0 0 0 0 0 - beta 2 0 0 5 3 8 4 - release 38 25 34 45 41 36 5 - esr 5 4 2 3 4 1 1 Affected platform: Windows
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox-esr45: --- → affected
I found only one crash with the alleged fix bug 1267980 https://crash-stats.mozilla.com/report/index/43e674af-875d-43b7-a574-c73542160628#allthreads worth reopen?
I think this can be considered actually fixed.
You need to log in before you can comment on or make changes to this bug.