If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix and suppress -Wunreachable-code-return warnings in media code

RESOLVED FIXED in Firefox 39

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
mozilla39
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8577664 [details] [diff] [review]
Wunreachable-code-return_media.patch

media/libstagefright/system/core/libutils/String16.cpp:272:16 [-Wunreachable-code-return] 'return' will never be executed
dom/media/fmp4/MP4Reader.cpp:1087:10 [-Wunreachable-code-return] 'return' will never be executed
Attachment #8577664 - Flags: review?(cajbir.bugzilla)

Updated

3 years ago
Attachment #8577664 - Flags: review?(cajbir.bugzilla) → review+
(Assignee)

Comment 1

3 years ago
Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a03e6ad02d30
https://hg.mozilla.org/mozilla-central/rev/a03e6ad02d30
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Updated

2 years ago
Depends on: 1235503
(Assignee)

Updated

2 years ago
Blocks: 1235717
You need to log in before you can comment on or make changes to this bug.