1143340 - Expose inspector markup preview setting

Status: RESOLVED WONTFIX

(DevTools :: Inspector, defect)

Description

[Tim Nguyen :ntim]

I think the inspector markup preview setting currently hidden in about:config (devtools.inspector.markupPreview) should be exposed in the devtools options panel.

It probably wasn't exposed because the options panel didn't exist at the time this was introduced (bug 793725).

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

The label tooltip is probably terrible, but I had no better idea.

Comment 2

[Patrick Brosset <:pbro>]

Do we want to keep the markup preview? Do we have telemetry of its usage? My guess is that since it's hidden, no one uses it.
My main gripe with it (aside from the fact that I'd never use such a feature) is that it takes space in the inspector, and we know we're struggling with nicely displaying nodes with lots of attributes already.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #2)
> Do we want to keep the markup preview? Do we have telemetry of its usage? My
> guess is that since it's hidden, no one uses it.

I'm fairly sure we don't have telemetry data on it, and I'm even more fairly sure that it's very rarely used (I've never heard anyone mention it or complain about the issues further down in this comment).

> My main gripe with it (aside from the fact that I'd never use such a
> feature) is that it takes space in the inspector, and we know we're
> struggling with nicely displaying nodes with lots of attributes already.

Yes, it overlays the nodes in the inspector and actually can cover up content that you can't see unless if you resize the markup view.  Additionally, you can't click and drag the region in the preview to scroll (which would be the most useful part of this feature wrt the markup view IMO.  And it disappears when you get to the bottom of a page.  We would need to do some work on this feature before endorsing it with a visible option in the options panel.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8577669 [details] [diff] [review]
Patch

Review of attachment 8577669 [details] [diff] [review]:
-----------------------------------------------------------------

See comment 3

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: markup-preview.png

Comment 6

[Patrick Brosset <:pbro>]

We don't plan to enable or make the markuppreview panel better (and in fact we removed it from the code).