Closed Bug 1143387 Opened 5 years ago Closed 5 years ago

Checked header button in share panel shouldn't have hover state

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: ntim, Assigned: abdelrahman, Mentored)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

To fix this :
At [0], you'll need to add :not([checked="true"]) at the end of the line.

[0] : http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#799
Assignee: nobody → a.ahmed1026
Status: NEW → ASSIGNED
Attachment #8579508 - Flags: review?(jaws)
(In reply to Tim Nguyen [:ntim] from comment #0)
> To fix this :
> At [0], you'll need to add :not([checked="true"]) at the end of the line.
> 
> [0] :
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> customizableui/panelUIOverlay.inc.css#799

When filing bugs, can you please include some steps to reproduce or a video/screenshot showing the problem? 

Is http://screencast.com/t/vuWFZ3PqRFmn what this bug is about (the hover state on the Facebook icon)?
Flags: needinfo?(ntim.bugs)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > To fix this :
> > At [0], you'll need to add :not([checked="true"]) at the end of the line.
> > 
> > [0] :
> > http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> > customizableui/panelUIOverlay.inc.css#799
> 
> When filing bugs, can you please include some steps to reproduce or a
> video/screenshot showing the problem? 
> 
> Is http://screencast.com/t/vuWFZ3PqRFmn what this bug is about (the hover
> state on the Facebook icon)?

Yes, that's exactly it.
Flags: needinfo?(ntim.bugs)
Comment on attachment 8579508 [details] [diff] [review]
rev 1 - disable hover state in checked header button

Review of attachment 8579508 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8579508 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/886cea0bebef
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/886cea0bebef
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.