Closed
Bug 1143387
Opened 11 years ago
Closed 11 years ago
Checked header button in share panel shouldn't have hover state
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: ntim, Assigned: abdelrahman, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
1.61 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
To fix this :
At [0], you'll need to add :not([checked="true"]) at the end of the line.
[0] : http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUIOverlay.inc.css#799
| Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #0)
> To fix this :
> At [0], you'll need to add :not([checked="true"]) at the end of the line.
>
> [0] :
> http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> customizableui/panelUIOverlay.inc.css#799
When filing bugs, can you please include some steps to reproduce or a video/screenshot showing the problem?
Is http://screencast.com/t/vuWFZ3PqRFmn what this bug is about (the hover state on the Facebook icon)?
Updated•11 years ago
|
Flags: needinfo?(ntim.bugs)
| Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> (In reply to Tim Nguyen [:ntim] from comment #0)
> > To fix this :
> > At [0], you'll need to add :not([checked="true"]) at the end of the line.
> >
> > [0] :
> > http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/
> > customizableui/panelUIOverlay.inc.css#799
>
> When filing bugs, can you please include some steps to reproduce or a
> video/screenshot showing the problem?
>
> Is http://screencast.com/t/vuWFZ3PqRFmn what this bug is about (the hover
> state on the Facebook icon)?
Yes, that's exactly it.
Flags: needinfo?(ntim.bugs)
Comment 4•11 years ago
|
||
Comment on attachment 8579508 [details] [diff] [review]
rev 1 - disable hover state in checked header button
Review of attachment 8579508 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8579508 -
Flags: review?(jaws) → review+
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 39
You need to log in
before you can comment on or make changes to this bug.
Description
•