Closed Bug 1143470 Opened 5 years ago Closed 5 years ago
_COMPONENT to moz .build files in toolkit and xulrunner
No description provided.
Comment on attachment 8577771 [details] [diff] [review] patch, v2 >diff --git a/toolkit/components/aboutcache/moz.build b/toolkit/components/aboutcache/moz.build >+with Files('**'): >+ BUG_COMPONENT = ('Core', 'Networking: Cache') I would use "General" here. >diff --git a/toolkit/components/commandlines/moz.build b/toolkit/components/commandlines/moz.build >+with Files('**'): >+ BUG_COMPONENT = ('Core', 'XPCOM') This is wrong - I would use "Startup and Profile System". >diff --git a/toolkit/components/crashes/moz.build b/toolkit/components/crashes/moz.build >+with Files('**'): >+ BUG_COMPONENT = ('Toolkit', 'Crashes') This component doesn't exist? I guess this can use Breakpad Integration. (Now I'm nervous that I haven't been checking the existence of all the other components in these patches...) >diff --git a/toolkit/components/xulstore/moz.build b/toolkit/components/xulstore/moz.build >+with Files('**'): >+ BUG_COMPONENT = ('Toolkit', 'Storage') This isn't quite right either. I would just use "General". r=me with these changes.
Attachment #8577771 - Flags: review?(gavin.sharp) → review+
(In reply to :Gavin Sharp [email: email@example.com] from comment #2) > (Now I'm nervous that I haven't been checking the existence of all the other > components in these patches...) Thank you for the correction and sorry for making you nervous. I haven't added Toolkit::General to /toolkit/moz.build to prevent the automatic coverage of the whole /toolkit - in case someone (like owners and peers) checks the directories not yet classified and provides the information. https://hg.mozilla.org/integration/mozilla-inbound/rev/d7310f807bdd
Thanks for doing this!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.