Add BUG_COMPONENT to moz.build files in toolkit and xulrunner

RESOLVED FIXED in Firefox 39

Status

()

Toolkit
General
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8577756 [details] [diff] [review]
patch, v1
Attachment #8577756 - Flags: review?(gavin.sharp)
Created attachment 8577771 [details] [diff] [review]
patch, v2
Assignee: nobody → archaeopteryx
Attachment #8577756 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8577756 - Flags: review?(gavin.sharp)
Attachment #8577771 - Flags: review?(gavin.sharp)
Comment on attachment 8577771 [details] [diff] [review]
patch, v2

>diff --git a/toolkit/components/aboutcache/moz.build b/toolkit/components/aboutcache/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Core', 'Networking: Cache')

I would use "General" here.

>diff --git a/toolkit/components/commandlines/moz.build b/toolkit/components/commandlines/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Core', 'XPCOM')

This is wrong - I would use "Startup and Profile System".

>diff --git a/toolkit/components/crashes/moz.build b/toolkit/components/crashes/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Toolkit', 'Crashes')

This component doesn't exist? I guess this can use Breakpad Integration.

(Now I'm nervous that I haven't been checking the existence of all the other components in these patches...)

>diff --git a/toolkit/components/xulstore/moz.build b/toolkit/components/xulstore/moz.build

>+with Files('**'):
>+    BUG_COMPONENT = ('Toolkit', 'Storage')

This isn't quite right either. I would just use "General".

r=me with these changes.
Attachment #8577771 - Flags: review?(gavin.sharp) → review+
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2)
> (Now I'm nervous that I haven't been checking the existence of all the other
> components in these patches...)
Thank you for the correction and sorry for making you nervous. I haven't added Toolkit::General to /toolkit/moz.build to prevent the automatic coverage of the whole /toolkit - in case someone (like owners and peers) checks the directories not yet classified and provides the information.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7310f807bdd
status-firefox39: --- → fixed
Target Milestone: --- → mozilla39
Thanks for doing this!
https://hg.mozilla.org/mozilla-central/rev/d7310f807bdd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.