Closed Bug 1143478 Opened 6 years ago Closed 6 months ago
47 bytes, text/x-phabricator-request
|Details | Review|
std::pair is used throughout the Firefox code base (https://dxr.mozilla.org/mozilla-central/search?q=std%3A%3Apair&redirect=true), including in lots libraries which we pull from upstream and aren't going to change. mozilla::pair is used almost nowhere (https://dxr.mozilla.org/mozilla-central/search?q=%2Btype-ref%3Amozilla%3A%3APair) I've heard claims that mozilla::pair exists to deal with implementation quality issues in std::pair (https://groups.google.com/forum/#!topic/mozilla.dev.platform/IQhGdhGxx2M) but as a practical matter, it seems clear that we've standardized on std::pair, so even if this is true, it's largely too late. I propose that we recognize the facts on the ground, remove mozilla::Pair, and recommend that people use the STL versions.
Attachment #9129376 - Attachment description: Bug 1143478 - Remove mozilla::Pair. r=froydnj → Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a08637fb30c8 Rename mozilla::Pair to CompactPair. r=froydnj
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/7a6232e87e8f Backed out changeset a08637fb30c8 for causing bustages in /builds/worker/checkouts/gecko/ipc/mscom/Registration.cpp CLOSED TREE
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4db022e14a60 Rename mozilla::Pair to CompactPair. r=froydnj
You need to log in before you can comment on or make changes to this bug.