1143502 - Use structural HTML5 elements instead of <div>

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

For readability, and to make life of accessibility tools easier, we should use the new header, nav, main and footer HTML5 elements. Those are understood by Chrome, Firefox, Safari and Opera for a long time. IE9+ only understand header, nav and footer, but not main. IE8 doesn't understand any. To work around IE8 limitations, we declare these new elements ourselves.

Comment 1

[David Lawrence [:dkl]]

Comment on attachment 8577787 [details] [diff] [review]
patch, v1

Review of attachment 8577787 [details] [diff] [review]:
-----------------------------------------------------------------

::: skins/standard/global.css
@@ +19,5 @@
> +
> +    /* header and footer are required for IE8. IE9+ support them natively.
> +     * main is required for all IE versions and KHTML-based browsers.
> +     * Other browsers support them natively already. */
> +    header, main, footer {

Don't we need nav here as well?

Comment 2

[Frédéric Buclin]

(In reply to David Lawrence [:dkl] from comment #1)
> Don't we need nav here as well?

No. <nav> is not a block.

Comment 3

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #2)
> (In reply to David Lawrence [:dkl] from comment #1)
> > Don't we need nav here as well?
> 
> No. <nav> is not a block.

Ah OK. Reason I asked as it is replacing a <div> and not a <span>

-    <div id="common_links">
+    <nav id="common_links">
       [% PROCESS "global/common-links.html.tmpl" qs_suffix = "_top" %]
-    </div>
+    </nav>

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8577787 [details] [diff] [review]
patch, v1

Review of attachment 8577787 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   fe75eda..d1c18ff  master -> master