Closed
Bug 1143511
Opened 11 years ago
Closed 11 years ago
Correct the usages of .catch() in DOM cache tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
4.27 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
These tests used .catch() incorrectly, in a way that did not actually
guarantee that the promise is rejected, so in 3 cases the promise
resolved to known failure values (undefined or an empty array) and
this was not being caught as a test failure.
This patch fixes those three places, and also rewrites the .catch()
usage in another case to guarantee that the promise is indeed rejected.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8577804 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ehsan
Blocks: cachetests
|
||
Updated•11 years ago
|
Attachment #8577804 -
Flags: review?(bkelly) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•