Closed Bug 1143539 Opened 6 years ago Closed 6 years ago

xpcshell tests in toolkit/components/downloads should be independent from firefox

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Only test_rep_windows.js relies on "general.useragent.locale" preference, so setting the preference value makes all tests in downloads independent from firefox.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd21eed65da5
Attachment #8577864 - Flags: review?(paolo.mozmail)
Comment on attachment 8577864 [details] [diff] [review]
remove_firefox-appdir_in_downloads.patch

Sometimes preferences are set to certain values by the test harness, and this is different from the value that clearUserPref results in. Probably, reading the previous preference value and restoring it is safer in this case.
Attachment #8577864 - Flags: review?(paolo.mozmail) → review+
Thanks!
This patch restores the previous value instead of clearUserPref.

Pushed a try for safety.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0fdb051bd16
Assignee: nobody → hiikezoe
Attachment #8577864 - Attachment is obsolete: true
Attachment #8578558 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f412765998a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.