1143561 - crash on VCMFrameBufferEnum VCMJitterBuffer::GetFrame

Status: RESOLVED DUPLICATE of bug 1158627

(Core :: WebRTC, defect)

Description

[karina]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.18 (KHTML, like Gecko) Version/8.0.3 Safari/600.3.18

Steps to reproduce:

make a call with FF squared client and squared iOS client


Actual results:

camera video can be showed about 2 or 3s. then crash.
crash info:

Assertion failed: (*frame), function GetFrame, file /Project/firefox/media/webrtc/trunk/webrtc/modules/video_coding/main/source/jitter_buffer.cc, line 663.




Expected results:

camera video can be viewed

Comment 1

[Ethan Hugg [:ehugg]]

Looking at the code here:
https://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/video_coding/main/source/jitter_buffer.cc#658

It appears  that RecycleFramesUntilKeyFrame did not free up any frames so the debug version will hit the assert and the release version would null deref a few lines later.  Perhaps we should replace the assert with something like 'return kGeneralError' to avoid a crash at least.

Comment 2

[karina]

(In reply to Ethan Hugg [:ehugg] from comment #1)
> Looking at the code here:
> https://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/
> modules/video_coding/main/source/jitter_buffer.cc#658
> 
> It appears  that RecycleFramesUntilKeyFrame did not free up any frames so
> the debug version will hit the assert and the release version would null
> deref a few lines later.  Perhaps we should replace the assert with
> something like 'return kGeneralError' to avoid a crash at least.
yes, we can return error in this case, but I am not sure whether there is a potential issue on this case.