1143634 - [mozharness] Remove dependency on fxos-appgen from web platform tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

As mentioned in bug 1038084 comment 3 and bug 1141590 comment 11, we no longer need fxos-appgen installed. Having it installed also prevents us from renaming the Marionette client for the branch.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Remove dependency on fxos-appgen. v1.0

Try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e26a682871 is against a user mozharness repository with this change and the patch from bug 1141590 to demonstrate that web platform tests are passing. I don't believe the other failures are related to this change. I used a mozilla-b2g37_v2_2 gecko branch with a tip from mozharness, which could explain the other failures.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Ryan: Could you take a look at the try results from comment 1 for me? Given my change I don't expect these to be related. The web platform tests are passing (which is what I was hoping for), and the Gip tests are failing (expected, as a gaia change will be required too when we reland bug 1141590). I suspect these failures are due to using a user mozharness based on tip with this change pushed, and the gecko change being based on v2.2.

If there's anything else you can recommend that I run to gain confidence of this patch then please advise, however the patch is pretty simple and I don't predict any issues (I've been wrong before though ;)).

Comment 3

[Ryan VanderMeulen [:RyanVM]]

The Gip failures look real:
https://treeherder.mozilla.org/logviewer.html#?job_id=5636998&repo=try

Nothing else looks problematic.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Yeah, the Gip failures are related to a missing Gaia patch that will land alongside the gecko patch on bug 1141590 (the Python package name needs to be updated in Gaia too). This mozharness patch will not cause those. Thanks Ryan!

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://hg.mozilla.org/build/mozharness/rev/0c2502eda454

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Armen: I'm confused about how I get this patch to be used by buildbot. As far as I can tell mozilla-central is pinned to a later revision, but looking at the Treeherder logs this patch is not applied. I need to get this patch being used by the mozilla-b2g37_v2_2 branch in buildbot to unblock some other work. Any chance you could help me out? :)

Comment 7

[Armen [:armenzg]]

Each tree pins to a specific revision.
In your case b2g37 points to [1] 7b5d3fcc48c6 [2] (changeset 3796) but you want it to point to 0c2502eda454 [3] (changeset 3784).

It seems your change is being using as of today:
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/log/07ccfb958d3b/testing/mozharness/mozharness.json
RyanVM merged some changes from mozilla-beta.

It seems that gilbert pointed on the 18th to mozharness' 7b5d3fcc48c6 [2]
https://hg.mozilla.org/releases/mozilla-beta/diff/a58b8b594396/testing/mozharness/mozharness.json

In other words, I think your issue is solved.

[1] https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/file/07ccfb958d3b/testing/mozharness/mozharness.json
[2] http://hg.mozilla.org/build/mozharness/rev/7b5d3fcc48c6
[3] https://hg.mozilla.org/build/mozharness/rev/0c2502eda454

Comment 8

[Jordan Lund (:jlund)]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Sorry, but changeset 7b5d3fcc48c6 does not include my change:

Current pointer (7b5d3fcc48c6):
https://hg.mozilla.org/build/mozharness/file/7b5d3fcc48c6/scripts/web_platform_tests.py#l102

My change (0c2502eda454):
https://hg.mozilla.org/build/mozharness/file/0c2502eda454/scripts/web_platform_tests.py#l101

Note that my change removed a line that is present in the revision pointed at. How can I get my mozharness change reflected in mozilla-central and mozilla-b2g37_v2_2?

Comment 10

[Armen [:armenzg]]

I see now what happened.
7b5d3fcc48c6 (cset 3796) is landed on the production branch.
0c2502eda454 (cset 3784) is landed on the default branch.
This graphical view allow us to see this:
https://hg.mozilla.org/build/mozharness/graph/3796

The safest thing to do would be to checkout 0c2502eda454 and create a head with your change.
This is the first time we use this new approach (creating new heads).
When pushing you will have to use -f since it will tell you that a new head is being created.
Please wait until I run this with releng one last time.

armenzg@armenzg-thinkpad:~/repos/hg/mozharness$ hg up -r 7b5d3fcc48c6 && hg export 0c2502eda454 > 1 && hg import 1
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
applying 1
armenzg@armenzg-thinkpad:~/repos/hg/mozharness$ hg out
comparing with ssh://hg.mozilla.org/build/mozharness
searching for changes
changeset:   3816:b522a404605e
branch:      production
tag:         tip
parent:      3796:7b5d3fcc48c6
user:        Dave Hunt <[e-mail]>
date:        Thu Mar 19 10:29:39 2015 +0000
summary:     Bug 1143634 - Remove dependency on fxos-appgen from web platform tests. r=jgriffin

armenzg@armenzg-thinkpad:~/repos/hg/mozharness$ hg heads
changeset:   3816:b522a404605e
branch:      production
tag:         tip
parent:      3796:7b5d3fcc48c6
user:        Dave Hunt <[e-mail]>
date:        Thu Mar 19 10:29:39 2015 +0000
summary:     Bug 1143634 - Remove dependency on fxos-appgen from web platform tests. r=jgriffin

changeset:   3815:8e4b18bf87b3
branch:      production
user:        ffxbld
date:        Tue Mar 24 22:36:57 2015 -0400
summary:     Added FIREFOX_37_0_RELEASE FIREFOX_37_0_BUILD1 tag(s) for changeset production. DONTBUILD CLOSED TREE a=release

changeset:   3811:2ca53a19719b
user:        Massimo Gervasini <[e-mail]>
date:        Tue Mar 24 15:41:45 2015 +0100
summary:     Bug 1144703 - Fix for missing locales in balrog submission. r=kmoir

Comment 11

[Armen [:armenzg]]

FYI, m-c already uses your change as of 41 hours ago:
http://hg.mozilla.org/build/mozharness/graph/3808

Next time if you want your change to be part of m-c, you can land on m-i a new change to mozharness.json pointing to your changeset.

Comment 12

[Armen [:armenzg]]

We're likely to need to create a branch in mozharness for b2g37_v2_2.
I will let you know by EOD.

Comment 13

[Armen [:armenzg]]

I created the branch, however, I made a small mistake.
Instead of branching from the production revision [1] I branched from the default revision [2].

You should now be abke to change mozharness.json on mozilla-b2g37_v2_2 to the new branch [3] which already includes your change.

However, there are 3 different changes also being included [4][5][6] because of my mistake.

I have reviewed all 3 changes and none of them affect b2g37.

In other words, you should be fine to bump mozilla-b2g37 to 72fbe7847a20 .

[1] https://hg.mozilla.org/build/mozharness/rev/7b5d3fcc48c6
[2] https://hg.mozilla.org/build/mozharness/rev/b7285d1f1272
[3] https://hg.mozilla.org/build/mozharness/rev/72fbe7847a20

[4] https://hg.mozilla.org/build/mozharness/rev/49eaa18e7aaf
[5] https://hg.mozilla.org/build/mozharness/rev/d99684a19ced
[6] https://hg.mozilla.org/build/mozharness/rev/effeda6b4441

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Giving this a go over on bug 1141590:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=102d056a69b2

Comment 15

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This is fixed now. Thanks!