1143651 - don't use CallQueryInterface when the compiler can do the cast for us

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't use CallQueryInterface when the compiler can do the cast for us

This is all older code, so the performance gain is not huge, but still.

Comment 2

[(no longer active)]

Comment on attachment 8578009 [details] [diff] [review]
don't use CallQueryInterface when the compiler can do the cast for us

Review of attachment 8578009 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xbl/nsXBLContentSink.cpp
@@ -39,5 @@
>    NS_ENSURE_ARG_POINTER(aResult);
>  
> -  nsXBLContentSink* it = new nsXBLContentSink();
> -
> -  nsCOMPtr<nsIXMLContentSink> kungFuDeathGrip = it;

This code is laughable!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/73d9939c6095