don't use CallQueryInterface when the compiler can do the cast for us

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

No description provided.
This is all older code, so the performance gain is not huge, but still.
Attachment #8578009 - Flags: review?(ehsan)
Comment on attachment 8578009 [details] [diff] [review]
don't use CallQueryInterface when the compiler can do the cast for us

Review of attachment 8578009 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/xbl/nsXBLContentSink.cpp
@@ -39,5 @@
>    NS_ENSURE_ARG_POINTER(aResult);
>  
> -  nsXBLContentSink* it = new nsXBLContentSink();
> -
> -  nsCOMPtr<nsIXMLContentSink> kungFuDeathGrip = it;

This code is laughable!
Attachment #8578009 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/73d9939c6095
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.