Remove the scroll position passed around in the scrollview event

RESOLVED FIXED in Firefox 39

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

See bug 1142926 comment 4 and bug 1142926 comment 7. The scrollview event dispatched starting at [1] includes a scroll position x,y which is nonsensical because it doesn't specify which scrollframe is being scrolled. Without this information the scroll position cannot possibly be interpreted in a sensical manner, leading to a footgun if anybody tries to use these values. Since the values are not being used anymore we should just remove them.

[1] mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/util/APZEventState.cpp?rev=f9b76a07fcc6#327
Whiteboard: [gfx-noted]
Posted patch Gecko patch (obsolete) — Splinter Review
This rips out the stuff on the gecko side. I noticed that in gaia/tv_apps/smart-system/js/text_selection_dialog.js there is still some code that uses the x and y scroll offsets - does that code need updating? It looks like a fork of gaia/apps/system/js/text_selection_dialog.js that is out of date.
Attachment #8580915 - Flags: feedback?(tlin)
Attachment #8580915 - Flags: feedback?(pchang)
Assignee: nobody → bugmail.mozilla
Attachment #8580915 - Flags: feedback?(pchang) → feedback?(mtseng)
Comment on attachment 8580915 [details] [diff] [review]
Gecko patch

Review of attachment 8580915 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good to me.
Attachment #8580915 - Flags: feedback?(tlin) → feedback+
I don't know how gaia/tv_apps/smart-system/js/text_selection_dialog.js is being used.

George, John, need your feedback about comment 1.
Flags: needinfo?(im)
Flags: needinfo?(gduan)
Comment on attachment 8580915 [details] [diff] [review]
Gecko patch

Review of attachment 8580915 [details] [diff] [review]:
-----------------------------------------------------------------

Kats, your probably forgot to add those changes to SelectionCarets.h in this patch.
Comment on attachment 8580915 [details] [diff] [review]
Gecko patch

LGTM.
Attachment #8580915 - Flags: feedback?(mtseng) → feedback+
We may not need it in smart-system. I will make a patch to remove that from smart-system.
Flags: needinfo?(im)
BTW, we are going to merge smart system back to system app.
TextSelectionDialog doesn't need value of scrollX and scrollY.
Flags: needinfo?(gduan)
Fixed up the header and another call site - not sure why I didn't catch those before. Based on the fact that the scroll position isn't used anywhere (the only use site will be removed as per comment 6) I think this should be safe to land now.
Attachment #8580915 - Attachment is obsolete: true
Attachment #8582391 - Flags: review?(roc)
Comment on attachment 8582391 [details] [diff] [review]
Remove scroll position from scrollviewchange event

Hm, the prevent_webidl_changes.py hg hook tells me I can't land this without DOM peer review because it touches a .webidl file.
Attachment #8582391 - Flags: review?(ehsan)
Attachment #8582391 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/584132a97872
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.