1143711 - .kt class does not have a style attached to it

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

jrmuizel and botond noticed this - when we syntax highlight C++ code, terms like "bool" are not highlighted.

Pygments correctly wraps "bool" in a span, and applies a "kt" class, but Review Board does not have a style associated with the kt class.

This will probably need to get fixed upstream, assuming we're somehow not doing something dumb here.

STR:

1) Push a review request to MozReview that has a .cpp file with the term "bool" in it.
2) View the diff for that review request, and inspect the "bool" text node

ER:

The bool text node should be wrapped in a span with class "kt" and there should be a style associated with kt.

AR:

The bool text node is wrapped in a span with class "kt", but there is no style associated with it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Associated Review Board bug: https://code.google.com/p/reviewboard/issues/detail?id=3809

Comment 2

[Mark Côté [:mcote]]

This appears to have been fixed at some point.  I see that .kt has the style {font-weight: bold;} associated with it.