Error in Firefox Health Report when health report preference is locked

RESOLVED WORKSFORME

Status

Firefox Health Report
Client: Desktop
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: mkaply, Unassigned)

Tracking

Trunk
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
In the CCK2 Wizard, I'm locking some the health report preference early, in particular:

Preferences.lock("datareporting.healthreport.uploadEnabled", false);

This results in the following error on the console:

1426523846470	Services.DataReporting.Policy	WARN	Exception when calling onRequestRemoteDelete: TypeError: this._s is null (resource://gre/modules/HealthReport.jsm:4056:4) JS Stack trace: HealthReporterState.prototype<.lastSubmitID@HealthReport.jsm:4056:5 < this.HealthReporter.prototype<.deleteRemoteData@HealthReport.jsm:5457:9 < DataReportingService.prototype<.onRequestRemoteDelete@DataReportingService.js:96:5 < _dispatchSubmissionRequest@DataReportingService.js:1463:7 < checkStateAndTrigger@DataReportingService.js:1305:7 < deleteRemoteData@DataReportingService.js:1210:5 < onUploadEnabledChanged@DataReportingService.js:750:5 < PrefObserver.prototype.observe@Preferences.jsm:415:9 < Preferences.prototype._set@Preferences.jsm:214:9 < Preferences.prototype.set@Preferences.jsm:144:5 < Preferences.prototype.lock@Preferences.jsm:334:7 < CCK2.init@CCK2.jsm:400:9 < CCK2nohealthService.prototype.observe@CCK2Service.js:56:9

The Health Report pref observer code should not display an error in this case.

In particular,

http://mxr.mozilla.org/mozilla-central/source/services/healthreport/healthreporter.jsm#118

should have a null check for _s, since the constructor for HealthReporterState sets _s to null.
FHR is going away per bug 1209088, closing.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.