Closed Bug 1143795 Opened 10 years ago Closed 10 years ago

Reduce font-weight of private browser identification overlay

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.2 S9 (3apr)

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] KevinGrandon:bug_1143795_adjust_identification_overlay_font_weight > mozilla-b2g:master
46 bytes, text/x-github-pull-request
kgrandon
: review+
epang
: ui-review+
Details | Review
From bug 1143206 comment 0: Also, can we reduce the font weight but one step? It's looking a little heavy. Unclear if this should be for all windows, or only private windows. Seems inconsistent if it's only for private windows.
Assignee: nobody → kgrandon
Whiteboard: [systemsfe]
Comment on attachment 8584786 [details] [review] [gaia] KevinGrandon:bug_1143795_adjust_identification_overlay_font_weight > mozilla-b2g:master Eric - can you take a look at this when you get a chance? I've adjusted the default font-weight 500 to 400. This impacts both private and normal windows. I have screenshots of the new identification overlay stylings with this patch on the pull request (I don't think you need to try it on a device unless you really want to). Thanks!
Attachment #8584786 - Flags: ui-review?(epang)
Comment on attachment 8584786 [details] [review] [gaia] KevinGrandon:bug_1143795_adjust_identification_overlay_font_weight > mozilla-b2g:master The images in the pull request look good to me, thanks for updating Kevin :)
Attachment #8584786 - Flags: ui-review?(epang) → ui-review+
Comment on attachment 8584786 [details] [review] [gaia] KevinGrandon:bug_1143795_adjust_identification_overlay_font_weight > mozilla-b2g:master Since this is a simple one-liner css patch with a ui-review, r=me.
Attachment #8584786 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S9 (3apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: