1143808 - 'New contact' button for adding new card still grayed/greyed out/disabled after selecting an addressbook (works after second selection)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

Thunderbird Daily 39.0a1 20150316 on Windows 8.1

Likely regression from bug 170270: Opening the address book has 'All Address Books' selected. The buttons 'New contact' and 'New list' are disabled. Selecting an address book (e.g. Personal Address Book) only enables 'New List'. Now clicking on the second address book also enables the 'New contant' button which remains enabled when returning to the first address book.

Comment 1

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v1

Comment 2

[:aceman]

Comment on attachment 8578164 [details] [diff] [review]
Patch v1

Review of attachment 8578164 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, seems to work for me.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8578164 [details] [diff] [review]
Patch v1

Review of attachment 8578164 [details] [diff] [review]:
-----------------------------------------------------------------

Yes. 
However, there seems to be be (at least) one case still missing. Once you select and address book and then select a contact only "new list" is enabled.

Comment 4

[Suyash Agarwal (:sshagarwal)]

So, new list will create anew list with the selected contact as one of list's contacts. What will new contact do?

Comment 5

[Magnus Melin [:mkmelin]]

It doesn't. I suppose it could start a new list of the selection if multiple contacts are selected, but afaik it never worked that way. 

For this bug in both cases it should just bring up the new contact/new list dialog, like it did in 31.

Comment 6

[Suyash Agarwal (:sshagarwal)]

Attachment: Patch v2

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 8581319 [details] [diff] [review]
Patch v2

Review of attachment 8581319 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

http://hg.mozilla.org/comm-central/rev/998ae30aabe8

Comment 9

[Kent James (:rkent)]

Comment on attachment 8581319 [details] [diff] [review]
Patch v2

http://hg.mozilla.org/releases/comm-aurora/rev/fe345de144d3