Add tests for the ignoreSearch match mode in DOM cache

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8578200 [details] [diff] [review]
Add tests for the ignoreSearch match mode in DOM cache
Attachment #8578200 - Flags: review?(bkelly)
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 1110493
Comment on attachment 8578200 [details] [diff] [review]
Add tests for the ignoreSearch match mode in DOM cache

Review of attachment 8578200 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Please add a test that ignores search and deals with fragments at the same time.
Attachment #8578200 - Flags: review?(bkelly) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Ben Kelly [:bkelly] from comment #2)
> LGTM.  Please add a test that ignores search and deals with fragments at the
> same time.

test_cache_matchAll_request.js already does that, by using a fragment for request1 but not request3, and ensuring that they are both returned from an ignoreSearch matchAll query.  Sorry if this was not obvious from the limited context.  :-)
https://hg.mozilla.org/mozilla-central/rev/ff73dd4e2d62
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.