1143869 - Fix wrong path in hg hook

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Ben Kero [:bkero]]

There is a bug in the hook the sys.path.append() call in one of the hg hooks (push-repo.py).

Comment 1

[Ben Kero [:bkero]]

Attachment: MozReview Request: bz://1143869/bkero

/r/5481 - hghooks: fix typo in push-repo.py hook

Pull down this commit:

hg pull review -r 47da4b2113e282904ef757e47ce5e2ab88f17db0

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8578267 [details]
MozReview Request: bz://1143869/bkero

https://reviewboard.mozilla.org/r/5479/#review4427

::: hghooks/mozhghooks/push_repo.py
(Diff revision 1)
>  job = MirrorJob(host, repo, cfg, None, True)
>  job.spawn_child()

This content is a giveaway: we don't use this file any more, right? Should we just delete it?

Comment 3

[Ben Kero [:bkero]]

Good idea. Looking closer at the file it's obvious that this is an unused relic.

Comment 4

[Ben Kero [:bkero]]

Comment on attachment 8578267 [details]
MozReview Request: bz://1143869/bkero

/r/5481 - hghooks: fix typo in push-repo.py hook

Pull down this commit:

hg pull review -r 47da4b2113e282904ef757e47ce5e2ab88f17db0

Comment 5

[Ben Kero [:bkero]]

Comment on attachment 8578267 [details]
MozReview Request: bz://1143869/bkero

/r/5481 - hghooks: fix typo in push-repo.py hook
/r/5495 - hghooks: remove old push_repo.py hook

Pull down these commits:

hg pull review -r bcb7d35460e5e4e3fe680164e365dc8101aef2fe

Comment 6

[Ben Kero [:bkero]]

Comment on attachment 8578267 [details]
MozReview Request: bz://1143869/bkero

https://reviewboard.mozilla.org/r/5479/#review4437

Ship It!

Comment 7

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/5481/#review4763

Ship It!

Comment 9

[Ben Kero [:bkero]]

Attachment: MozReview Request: hghooks: remove old push_repo.py hook

Comment 10

[Ben Kero [:bkero]]

Attachment: MozReview Request: hghooks: remove old push_repo.py hook