Closed Bug 1143924 Opened 9 years ago Closed 9 years ago

Remove added code from generated wrapper files

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(1 file, 2 obsolete files)

fix-generated.diff
207.95 KB, patch
u480271
: review+
Details | Diff | Splinter Review 
Some extra code has snuck in, and we should move it back out.
Attachment #8578328 - Flags: review?(dglastonbury)
Comment on attachment 8578328 [details] [diff] [review]
0001-Remove-code-additions-from-generated-wrappers.patch

Review of attachment 8578328 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with green try run.
Attachment #8578328 - Flags: review?(dglastonbury) → review+
Let's try to warn people off of editing our generated files.
Attachment #8578789 - Flags: review?(dglastonbury)
Comment on attachment 8578789 [details] [diff] [review]
0002-Add-GENERATED-FILE-comment-to-_wrapper-files.patch

Review of attachment 8578789 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe split the generated files from the changed files next time.
Attachment #8578789 - Flags: review?(dglastonbury) → review+
Ok, so there were some false starts in there. Here's what passes on Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=faf7907d1fc7
Attachment #8578328 - Attachment is obsolete: true
Attachment #8578789 - Attachment is obsolete: true
Attachment #8580477 - Flags: review?(dglastonbury)
Attachment #8580477 - Flags: review?(dglastonbury) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #5)
> Created attachment 8580477 [details] [diff] [review]
> fix-generated.diff
> 
> Ok, so there were some false starts in there. Here's what passes on Try:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=faf7907d1fc7

Might be worth throwing in 10.8 and 10.10 for testing too.
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7926689&repo=mozilla-inbound
Flags: needinfo?(jgilbert)
https://hg.mozilla.org/mozilla-central/rev/cd28897da642
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: