Closed
Bug 1143932
Opened 9 years ago
Closed 9 years ago
Factor out code from emit_from_context
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox39 fixed)
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(8 files, 1 obsolete file)
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
gps
:
review+
|
Details |
This function is way too big.
|
||
Comment 1•9 years ago
|
||
FWIW, I have a patch sitting somewhere to move library/program-related stuff to a separate function.
|
|
||
Comment 2•9 years ago
|
||
(it's probably outdated, though)
|
Assignee | |
Comment 3•9 years ago
|
||
/r/5509 - Bug 1143932 - Factor out library handling code from emit_from_context; r=gps /r/5511 - Bug 1143932 - Factor out test manifest processing code from emit_from_context; r=gps /r/5513 - Bug 1143932 - Factor out sources processing code from emit_from_context; r=gps /r/5515 - Bug 1143932 - Factor out jar manifest processing code from emit_from_context; r=gps /r/5517 - Bug 1143932 - Factor out generated filed processing code from emit_from_context; r=gps /r/5519 - Bug 1143932 - Factor out programs processing code from emit_from_context; r=gps /r/5521 - Bug 1143932 - Factor out XPIDL processing code from emit_from_context; r=gps /r/5523 - Bug 1143932 - Factor out test harness files processing code from emit_from_context; r=gps Pull down these commits: hg pull review -r 0e908fb0ec4ae4d00be8c5f950d5b275941a7db8
Attachment #8578343 -
Flags: review?(gps)
|
||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/5509/#review4471 Ship It!
|
|
||
Comment 5•9 years ago
|
||
https://reviewboard.mozilla.org/r/5511/#review4473 Ship It!
|
|
||
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/5513/#review4475 Ship It!
|
|
||
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/5515/#review4477 Ship It!
|
|
||
Comment 8•9 years ago
|
||
https://reviewboard.mozilla.org/r/5517/#review4479 ::: python/mozbuild/mozbuild/frontend/emitter.py (Diff revision 1) > + if generated_files: I typically prefer early return in these scenarios to avoid extra indentation. Feel free to fix it on the fly.
|
|
||
Comment 9•9 years ago
|
||
https://reviewboard.mozilla.org/r/5519/#review4481 Ship It!
|
|
||
Comment 10•9 years ago
|
||
https://reviewboard.mozilla.org/r/5521/#review4483 Ship It!
|
|
||
Comment 11•9 years ago
|
||
https://reviewboard.mozilla.org/r/5523/#review4485 ::: python/mozbuild/mozbuild/frontend/emitter.py (Diff revision 1) > + if test_harness_files: Early return.
|
|
||
Comment 12•9 years ago
|
||
Comment on attachment 8578343 [details] MozReview Request: bz://1143932/Ms2ger https://reviewboard.mozilla.org/r/5507/#review4487 Review Board's rendering of detected content moving pretty much made this patch a no-brainer to review. I love using diff tools that aid me.
Attachment #8578343 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eccc8910a251 https://hg.mozilla.org/integration/mozilla-inbound/rev/cf13977aa4fa https://hg.mozilla.org/integration/mozilla-inbound/rev/371a2c961926 https://hg.mozilla.org/integration/mozilla-inbound/rev/6670f5380a40 https://hg.mozilla.org/integration/mozilla-inbound/rev/4a493366d2e9 https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea00e33ac02 https://hg.mozilla.org/integration/mozilla-inbound/rev/9e27b05b961f https://hg.mozilla.org/integration/mozilla-inbound/rev/845715f861df
|
||
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eccc8910a251 https://hg.mozilla.org/mozilla-central/rev/cf13977aa4fa https://hg.mozilla.org/mozilla-central/rev/371a2c961926 https://hg.mozilla.org/mozilla-central/rev/6670f5380a40 https://hg.mozilla.org/mozilla-central/rev/4a493366d2e9 https://hg.mozilla.org/mozilla-central/rev/7ea00e33ac02 https://hg.mozilla.org/mozilla-central/rev/9e27b05b961f https://hg.mozilla.org/mozilla-central/rev/845715f861df
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
|
Assignee | |
Comment 15•9 years ago
|
||
Attachment #8578343 -
Attachment is obsolete: true
Attachment #8619773 -
Flags: review+
Attachment #8619774 -
Flags: review+
Attachment #8619775 -
Flags: review+
Attachment #8619776 -
Flags: review+
Attachment #8619777 -
Flags: review+
Attachment #8619778 -
Flags: review+
Attachment #8619779 -
Flags: review+
Attachment #8619780 -
Flags: review+
|
|
Assignee | |
Comment 16•9 years ago
|
||
|
|
Assignee | |
Comment 17•9 years ago
|
||
|
|
Assignee | |
Comment 18•9 years ago
|
||
|
|
Assignee | |
Comment 19•9 years ago
|
||
|
|
Assignee | |
Comment 20•9 years ago
|
||
|
|
Assignee | |
Comment 21•9 years ago
|
||
|
|
Assignee | |
Comment 22•9 years ago
|
||
|
|
Assignee | |
Comment 23•9 years ago
|
||
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•