Reroute all fetch tests through transparent serviceworker

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nsm, Assigned: Ehsan)

Tracking

unspecified
mozilla41
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

This will allow us to make sure that a serviceworker that just forwards requests to fetch() acts like it isn't there and deals with cors/opaque response headers correctly.
(Assignee)

Comment 1

3 years ago
Created attachment 8605292 [details] [diff] [review]
Reroute all fetch tests through a transparent service worker
Attachment #8605292 - Flags: review?(nsm.nikhil)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Comment on attachment 8605292 [details] [diff] [review]
Reroute all fetch tests through a transparent service worker

Review of attachment 8605292 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the <title>Bug XXXXXXX...</title> in all files. r=me with that.

::: dom/tests/mochitest/fetch/fetch_test_framework.js
@@ +117,5 @@
>        info(e.message);
>        return Promise.resolve();
>      })
>      .then(function() {
> +      if (parent.finishTest) {

if (parent && parent.finishTest) {

since this is used in the top level non-sw-intercepted tests.
Attachment #8605292 - Flags: review?(nsm.nikhil) → review+
https://hg.mozilla.org/mozilla-central/rev/1189f6ffc65e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.