EME decoder should be using SharedDecoderManager

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla39
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
SharedDecoderManager was disabled when content is encrypted.

With bug 1128381, it is now safe to use SharedDecoderManager with the EME PDM.
(Assignee)

Comment 1

4 years ago
Created attachment 8578416 [details] [diff] [review]
Use SharedDecoderManager with EME PDM

Use SDM with EME.
Attachment #8578416 - Flags: review?(cpearce)
(Assignee)

Updated

4 years ago
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Attachment #8578416 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/f46c7fbdfb00
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 4

4 years ago
I think this should be uplifted.

we know how much not having dormant on win32 introduced memory issues. Without this we will also have one complete decoder (and all its buffer) per resolution played

Now with EME becoming mainstream, this would greatly help.
Flags: needinfo?(cpearce)
Comment on attachment 8578416 [details] [diff] [review]
Use SharedDecoderManager with EME PDM

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: This patch reduces the number of decoders we potentially create when playing EME video. This potentially will reduce the memory consumption when playing EME videos, and thus reduce the liklihood of out-of-memory crashes.
[Describe test coverage new/current, TreeHerder]: We're shipping this "shared decoder" feature for non-EME video, so it's exercised well there, and of course exercised in our mochitests.
[Risks and why]: Low; potential for breaking decoders, but we've been using this path on non-EME video for a few weeks so we should be OK.
[String/UUID change made/needed]: None.
Attachment #8578416 - Flags: approval-mozilla-aurora?
Attachment #8578416 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Needs rebasing for Aurora uplift.
Flags: needinfo?(jyavenard)
I'll take care of it.
Flags: needinfo?(jyavenard)
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.