1144081 - Some buttons and menus (if drawInTitlebar is true) now require a double click to function

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150316163014

Steps to reproduce:

1. Install LastPass for Firefox.

2. Insure LP button is on a toolbar, Nav, Bookmarks for example.


Actual results:

Hovering over the button does not produce a hover color nor does clicking on the button bring up the LP context menu.  Now you have to double-click to use the button.


Expected results:

LP button should have a hover color when pointer is placed over it.  A single click should be all that is needed to bring up the context menu.

Comment 1

[Gary [:streetwolf52]]

Regression Range

Good:  https://hg.mozilla.org/integration/mozilla-inbound/rev/ff27f90ed289

Bad:   https://hg.mozilla.org/integration/mozilla-inbound/rev/24640e5e0d3d

Comment 2

[Jan de Mooij [:jandem]]

So the range is:

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ff27f90ed289&tochange=24640e5e0d3d

You posted in bug 1142814 but bug 1143567 seems more likely...

Comment 3

[Gary [:streetwolf52]]

When I go to the 'bad' cset all I see is the one patch.  How do I see the other patches that fall within this cset?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Construct a URL like so: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ff27f90ed289&tochange=24640e5e0d3d with the fromchange being the "good" and tochange being the "bad"

Comment 5

[Loic]

[Tracking Requested - why for this release]:

Comment 6

[Gary [:streetwolf52]]

Just discovered that the options button (to the left of the search box) on about:addons also requires a double click whereas before a single click opened up the context menu.  I'm sure their are other buttons similarly affected.

Comment 7

[Gary [:streetwolf52]]

The Back/Forward buttons now require a double click to work as well as having no hover color.

Comment 8

[Gary [:streetwolf52]]

Just one more for you.  The search engine buttons on the search bar also require a double click.

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Tracking for 39. 
David, can you take a look since this may be a regression from your patch in bug 1143567. Thanks!

Comment 10

[Jim Jeffery not reading bug-mail 1/2/11]

Confriming and setting to NEW,  seeing the same on m-c win7 x64 win32 build.

Comment 11

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Last good: http://hg.mozilla.org/integration/mozilla-inbound/rev/59bc41a51a2b

First bads are after bug 1143567 landed. Commits:

http://hg.mozilla.org/integration/mozilla-inbound/rev/1727096f4b48
http://hg.mozilla.org/integration/mozilla-inbound/rev/311dd54d806b
http://hg.mozilla.org/integration/mozilla-inbound/rev/d47ee5553045
http://hg.mozilla.org/integration/mozilla-inbound/rev/5e93ac53e79c

Comment 12

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Accidentally assigned nsEventStatus to bool. Whoops.

Comment 13

[Jim Mathies [:jimm]]

Comment on attachment 8578791 [details] [diff] [review]
fix

(In reply to David Anderson [:dvander] from comment #12)
> Created attachment 8578791 [details] [diff] [review]
> fix
> 
> Accidentally assigned nsEventStatus to bool. Whoops.

..and I missed it in the review. whoops x 2.

Comment 14

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d45aaa6d2217

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d45aaa6d2217

Comment 21

[u428464]

Right click on the same items is still broken after the respin.

Comment 22

[leichixian]

Not fixed totally. Now right click on a bookmark does nothing. Actually only single left click fixed

Comment 23

[Ajay Gupta]

It's working fine for me. Right-Clicking on a bookmark opens a context menu for me.

Comment 24

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

The follow up issue is in bug #1144827.